Bug 231631 - www/squid3 does not build with ECAP option
Summary: www/squid3 does not build with ECAP option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Thomas Zander
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2018-09-23 12:36 UTC by Thomas Zander
Modified: 2018-09-29 16:13 UTC (History)
2 users (show)

See Also:
riggs: maintainer-feedback+
riggs: merge-quarterly-

Attachments
svn-diff-squid3 (1.26 KB, patch)
2018-09-24 18:38 UTC, Walter Schwarzenfeld 		koobs: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Zander freebsd_committer freebsd_triage 2018-09-23 12:36:13 UTC 
When building squid3 3.5.28 with ECAP option, the build breaks at:

...
libtool: compile:  c++ -DHAVE_CONFIG_H -I../../.. -I../../../include -I../../../lib -I../../../src -I../../../include -I/usr/include -I/usr/include -I../../../libltdl -I/usr/include -I/usr/local/include -I/usr/local/include -I/usr/include -I/usr/include -O2 -pipe -I/usr/local/include -fstack-protector -fno-strict-aliasing -Wno-unknown-warning-option -Wno-undefined-bool-conversion -Wno-tautological-undefined-compare -Wno-dynamic-class-memaccess -I/usr/local/include -MT libsquid_ecap_la-Config.lo -MD -MP -MF .deps/libsquid_ecap_la-Config.Tpo -c Config.cc -o libsquid_ecap_la-Config.o >/dev/null 2>&1
--- libsquid_ecap_la-ServiceRep.lo ---
ServiceRep.cc:237:12: error: no viable conversion from returned value of type 'const Adaptation::Ecap::ServiceRep::AdapterService' (aka 'const shared_ptr<libecap::adapter::Service>') to function return type 'bool'
    return theService;
           ^~~~~~~~~~
1 error generated.
*** [libsquid_ecap_la-ServiceRep.lo] Error code 1
Comment 1 Walter Schwarzenfeld 2018-09-24 18:38:10 UTC 
Created attachment 197460 [details]
svn-diff-squid3

If I am right, this should fix it.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2018-09-25 06:22:51 UTC 
Reporter is committer, assign accordingly
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2018-09-25 06:23:50 UTC 
Comment on attachment 197460 [details]
svn-diff-squid3

Changesets fixing build/run/package errors are:

Approved by: portmgr (blanket: build, run or package fix)
Comment 4 Pavel Timofeev 2018-09-29 10:31:49 UTC 
(In reply to Thomas Zander from comment #0)
What OS do you use?
I can not reproduce this error on FreeBSD 11.2-RELEASE amd64
Comment 5 Thomas Zander freebsd_committer freebsd_triage 2018-09-29 13:44:56 UTC 
(In reply to timp87 from comment #4)

This is in an 11.2-RELEASE-p4 amd64 poudriere jail.

Attachment #197460 [details] fixes this problem by explicitly returning the bool type. Are you okay if I commit this?
Comment 6 Pavel Timofeev 2018-09-29 13:46:07 UTC 
(In reply to Thomas Zander from comment #5)
Sure!
Comment 7 commit-hook freebsd_committer freebsd_triage 2018-09-29 14:39:20 UTC 
A commit references this bug:

Author: riggs
Date: Sat Sep 29 14:39:17 UTC 2018
New revision: 480908
URL: https://svnweb.freebsd.org/changeset/ports/480908

Log:
  Fix build with ECAP OPTION

  PR:		231631
  Submitted by:	w.schwarzenfeld@utanet.at (patch file)
  Reported by:	riggs
  Approved by:	timp87@gmail.com (maintainer)

Changes:
  head/www/squid3/Makefile
  head/www/squid3/files/patch-ServiceRep.cc
Comment 8 Thomas Zander freebsd_committer freebsd_triage 2018-09-29 16:13:57 UTC 
Committed, thanks!

Not MFH'ed to 2018Q3 since there is no www/squid3 port.