Comment 1 Guido Falsi 2018-09-26 13:54:00 UTC

Hi,

Adding the option is no problem, but why enable it by default?

I'd be more inclined to have it disabled by default also because other xfce4 port which have this option have it disabled by default (see misc/xfce4-weather-plugin).

BTW when using ${OPT}_CONFIGURE_ENABLE you don't need to specify the --disable in CONFIGURE_ARGS. The option helper does that itself if the option is disabled.

I'll test with this option, but my intention is to commit it as disabled by default.

Comment 2 Guido Falsi 2018-09-26 13:56:06 UTC

(In reply to Guido Falsi from comment #1)
> Hi,
> 
> Adding the option is no problem, but why enable it by default?
> 
> I'd be more inclined to have it disabled by default also because other xfce4
> port which have this option have it disabled by default (see
> misc/xfce4-weather-plugin).
> 
> BTW when using ${OPT}_CONFIGURE_ENABLE you don't need to specify the
> --disable in CONFIGURE_ARGS. The option helper does that itself if the
> option is disabled.
> 
> I'll test with this option, but my intention is to commit it as disabled by
> default.

Sorry, I misinterpreted your patch.

So it is actually at present upower is mandatory, so making it enabled by default is the obvious choice. No need anyway for the CONFIGURE_ARGS line though.

So I'll test this patch with the default option to on.

Comment 3 commit-hook 2018-09-27 08:53:42 UTC

A commit references this bug:

Author: madpilot
Date: Thu Sep 27 08:53:03 UTC 2018
New revision: 480791
URL: https://svnweb.freebsd.org/changeset/ports/480791

Log:
  - Add UPOWER option to xfce4-systemload-plugin, enabled by default
    since it was mandatory before [1]
  - While here cleanup and silence one portlint warning

  PR:		231731 [1]
  Submitted by:	Ali Abdallah <aliovx@gmail.com>

Changes:
  head/sysutils/xfce4-systemload-plugin/Makefile

Comment 4 Guido Falsi 2018-09-27 08:53:50 UTC

Committed. Thanks!