Bug 231776 - mail/isync: does not compile with openssl 1.1.1
Summary: mail/isync: does not compile with openssl 1.1.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-28 11:45 UTC by Sascha Holzleiter
Modified: 2018-10-16 07:47 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (ehaupt)

Attachments
isync_openssl111 patch (1.43 KB, patch)
2018-10-02 14:36 UTC, Sascha Holzleiter 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sascha Holzleiter 2018-09-28 11:45:24 UTC 
Trying to build isync with ssl=openssl111 results in a linker error:

https://pkgs.blumenschaender.de/data/112amd64-default-desk111/2018-09-28_12h16m36s/logs/errors/isync-1.3.0.log

Adding this to the Makefile:

MAKE_ARGS+=     SSL_LIBS="-L${OPENSSLLIB} -lssl -lcrypto"

This builds successfully but with a few warnings:

https://pkgs.blumenschaender.de/data/112amd64-default-desk111/2018-09-28_13h41m38s/logs/isync-1.3.0.log

As i am no programmer i actually have no clue if this is the right fix ;)
I can't test the successfully build binary until next week, as this is my desktop at work which i can't update before the weekend...
Comment 1 Sascha Holzleiter 2018-10-02 14:36:57 UTC 
Created attachment 197714 [details]
isync_openssl111 patch

I've been using the resulting binary today with no side effects on my end.
This patch adds the MAKE_ARGS fix to the port and also includes an openssl 1.1.1 fix from upstream as some providers seem to require SNI when TLSv1.3 is used (https://sourceforge.net/p/isync/mailman/message/36410738/).
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-10-16 07:44:10 UTC 
A commit references this bug:

Author: ehaupt
Date: Tue Oct 16 07:43:32 UTC 2018
New revision: 482205
URL: https://svnweb.freebsd.org/changeset/ports/482205

Log:
  - Fix build with openssl 1.1.1 / unbreak on 12.0-ALPHA9 [1]
  - Merge a patch from upstream as some providers seem to require SNI when
    TLSv1.3 is used
  - Pacify portlint

  PR:		231776
  Submitted by:	Sascha Holzleiter <sascha@root-login.org>
  Notified by:	pkg-fallout [1]
  MFH:		2018Q4 (blanket)

Changes:
  head/mail/isync/Makefile
  head/mail/isync/files/patch-src_socket.c
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-10-16 07:46:13 UTC 
A commit references this bug:

Author: ehaupt
Date: Tue Oct 16 07:45:54 UTC 2018
New revision: 482206
URL: https://svnweb.freebsd.org/changeset/ports/482206

Log:
  MFH: r482205

  - Fix build with openssl 1.1.1 / unbreak on 12.0-ALPHA9 [1]
  - Merge a patch from upstream as some providers seem to require SNI when
    TLSv1.3 is used
  - Pacify portlint

  PR:		231776
  Submitted by:	Sascha Holzleiter <sascha@root-login.org>
  Notified by:	pkg-fallout [1]
  Approved by:	ports-secteam (blanket)

Changes:
_U  branches/2018Q4/
  branches/2018Q4/mail/isync/Makefile
  branches/2018Q4/mail/isync/files/patch-src_socket.c
Comment 4 Emanuel Haupt freebsd_committer freebsd_triage 2018-10-16 07:47:16 UTC 
Thank you for the excellent patch. I've merged the upstream patch with the existing patch and merged the changes to quarterly.