Bug 231786 - dns/bind912: fix build on powerpc64
Summary: dns/bind912: fix build on powerpc64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mathieu Arnold
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-09-28 15:18 UTC by Piotr Kubaj
Modified: 2018-11-02 10:00 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (mat)

Attachments
patch (478 bytes, patch)
2018-09-28 15:18 UTC, Piotr Kubaj 		no flags Details | Diff
Patch (515 bytes, patch)
2018-09-29 05:00 UTC, Nathan 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2018-09-28 15:18:29 UTC 
Created attachment 197573 [details]
patch

USES=compiler:c11 needs to be declared on powerpc64 to build successfully.

Tested on powerpc64 and amd64

Hardware sponsored by IntegriCloud.
Comment 1 Nathan 2018-09-29 04:21:53 UTC 
Gonna see if it builds on mips without compiler:c*, as it breaks mips
Comment 2 Nathan 2018-09-29 04:51:42 UTC 
(In reply to Nathan from comment #1)
This would break mips Gonna come up with an alternative patch
Comment 3 Nathan 2018-09-29 05:00:08 UTC 
Created attachment 197587 [details]
Patch

Test this, as it should only affect powerpc64 and still allow it to work on mips. Otherwise adding compiler:c11 will break mips/mips64 because compiler: pulls gcc and gcc is not available for mips-based
Comment 4 Piotr Kubaj freebsd_committer freebsd_triage 2018-09-29 17:20:57 UTC 
(In reply to Nathan from comment #3)
Yes, that works as well.
Comment 5 Mathieu Arnold freebsd_committer freebsd_triage 2018-10-03 08:12:06 UTC 
Could you check the other dns/bind9 ports?
Comment 6 Piotr Kubaj freebsd_committer freebsd_triage 2018-10-03 08:20:18 UTC 
(In reply to Mathieu Arnold from comment #5)
I will, I'm running poudriere bulk -a for powerpc64.
Comment 7 Piotr Kubaj freebsd_committer freebsd_triage 2018-10-20 12:12:04 UTC 
(In reply to Mathieu Arnold from comment #5)
dns/bind9-devel also requires it.
Comment 8 Piotr Kubaj freebsd_committer freebsd_triage 2018-10-21 15:42:06 UTC 
(In reply to Mathieu Arnold from comment #5)
dns/bind913 is also affected.
Comment 9 Piotr Kubaj freebsd_committer freebsd_triage 2018-10-21 15:42:33 UTC 
dns/bind911 builds ok, so I guess it's only 9.12 and newer that need it.
Comment 10 commit-hook freebsd_committer freebsd_triage 2018-11-02 10:00:35 UTC 
A commit references this bug:

Author: mat
Date: Fri Nov  2 09:59:47 UTC 2018
New revision: 483797
URL: https://svnweb.freebsd.org/changeset/ports/483797

Log:
  Fix build on powerpc64.

  PR:		231786
  Submitted by:	Piotr Kubaj

Changes:
  head/dns/bind9-devel/Makefile
  head/dns/bind912/Makefile
  head/dns/bind913/Makefile