Bug 231808 - security/yubikey-personalization-gui: switch to qt5
Summary: security/yubikey-personalization-gui: switch to qt5
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Romain Tartière
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2018-09-29 20:51 UTC by Christoph Moench-Tegeder
Modified: 2018-10-04 13:45 UTC (History)
0 users

See Also:
romain: maintainer-feedback+

Attachments
switch to Qt5 (785 bytes, patch)
2018-09-29 20:51 UTC, Christoph Moench-Tegeder 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christoph Moench-Tegeder freebsd_committer freebsd_triage 2018-09-29 20:51:05 UTC 
Created attachment 197608 [details]
switch to Qt5

yubikey-personalization-gui can be built with Qt 5 - in fact, as per https://github.com/Yubico/yubikey-personalization-gui/blob/master/NEWS#L23 that's already the default for certain platforms. With Qt 4 being rather old, let's switch this port to the more recent version.
Attached patch does this trick for me (and passes poudriere).
Comment 1 Romain Tartière freebsd_committer freebsd_triage 2018-10-04 12:58:41 UTC 
Thanks for reminding me this!  I have a local patch for building against QT4 or QT5.  Seems to be a conflict at the moment, will fix this and commit!
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-10-04 13:44:51 UTC 
A commit references this bug:

Author: romain
Date: Thu Oct  4 13:43:48 UTC 2018
New revision: 481222
URL: https://svnweb.freebsd.org/changeset/ports/481222

Log:
  Build against QT5 by default

  QT4 is still supported and options where introduced to allow users to choose
  which version of QT they want yubikey-personalization-gui to be built against.

  While here, pet portlint.

  Since the version of QT change, bump PORTREVISION.

  PR:		231808
  Reported by:	cmt

Changes:
  head/security/yubikey-personalization-gui/Makefile
Comment 3 Romain Tartière freebsd_committer freebsd_triage 2018-10-04 13:45:35 UTC 
Committed, thanks!