Bug 232015 - astro/celestia: fix build with GCC-based architectures
Summary: astro/celestia: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mark Linimon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-06 19:02 UTC by Piotr Kubaj
Modified: 2018-10-31 13:09 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (danfe)


Attachments
patch (630 bytes, patch)
2018-10-06 19:04 UTC, Piotr Kubaj
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2018-10-06 19:02:15 UTC

    
Comment 1 Piotr Kubaj freebsd_committer freebsd_triage 2018-10-06 19:03:41 UTC
Sorry, I pressed enter too quickly.

This port needs USES=compiler:c++11-lang to fix build on GCC architectures.

While here, I also add USES=gnome.

Tested on amd64 and powerpc64.

Hardware sponsored by IntegriCloud.
Comment 2 Piotr Kubaj freebsd_committer freebsd_triage 2018-10-06 19:04:01 UTC
Created attachment 197850 [details]
patch
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-10-28 11:17:15 UTC
A commit references this bug:

Author: linimon
Date: Sun Oct 28 11:16:35 UTC 2018
New revision: 483276
URL: https://svnweb.freebsd.org/changeset/ports/483276

Log:
  Fix build with GCC-based architectures.

  PR:		232015
  Submitted by:	Piotr Kubaj
  Approved by:	portmgr (tier-2 blanket)

Changes:
  head/astro/celestia/Makefile
Comment 4 Alexey Dokuchaev freebsd_committer freebsd_triage 2018-10-31 03:22:44 UTC
Piotr, could you please attach the excerpt from the build log with the error you're seeing?  I cannot reproduce it on powerpc (which is gcc-4.2.1-based).
Comment 5 Piotr Kubaj freebsd_committer freebsd_triage 2018-10-31 13:09:54 UTC
(In reply to Alexey Dokuchaev from comment #4)
I don't have the build logs that old now due to space constraints.

I see this package builds straight from the ports tree with base GCC. I'll try to build it with base GCC in my next Poudriere run and see whether it builds.