Created attachment 197954 [details] Proposed patch (since 475857 revision) Patch to update deskutils/treesheets port from 1.0.0 to 1.0.1 version. Look following link for changes: https://github.com/aardappel/treesheets/compare/v1.0.0...v1.0.1 - Use C++17 compatible compiler for build [1] - Adapt value for PORTDATA variable to install "scripts" and "translations" directories - Fix build for FreeBSD 10, with using appropriate libc++ include files Reference links: 1. Now always requiring C++17 https://github.com/aardappel/treesheets/commit/2b657dc5a8ca645d11dfcb5f64a114e5d53c26d1 The build was tested on FreeBSD 10.4 amd64.
Created attachment 197955 [details] Proposed patch (since 475857 revision)
The following block probably needs a comment with explanation of the need for it, if nothing else than to help the reviewer/committer grok/evaluate the pattern: +.if (${OPSYS} == FreeBSD && ${OSVERSION} < 1100000) || make(makesum)
Created attachment 197956 [details] Proposed patch (since 475857 revision) (In reply to Kubilay Kocak from comment #2) > The following block probably needs a comment with explanation of the need > for it, <..> > +.if (${OPSYS} == FreeBSD && ${OSVERSION} < 1100000) || make(makesum) Ok, I added some comment for related block. Some examples of related errors, if not using this: -8<-- % make <..> In file included from lobster_impl.cpp:2: In file included from ../lobster/src/lobster/stdafx.h:42: In file included from /usr/include/c++/v1/unordered_map:350: /usr/include/c++/v1/__hash_table:1165:43: error: conflicting types for '__hash_table<_Tp, _Hash, _Equal, _Alloc>' __hash_table<_Tp, _Hash, _Equal, _Alloc>::__hash_table() ^ /usr/include/c++/v1/__hash_table:852:5: note: previous declaration is here __hash_table() ^ /usr/include/c++/v1/__hash_table:1233:43: error: conflicting types for '__hash_table<_Tp, _Hash, _Equal, _Alloc>' __hash_table<_Tp, _Hash, _Equal, _Alloc>::__hash_table(__hash_table&& __u) ^ /usr/include/c++/v1/__hash_table:866:5: note: previous declaration is here __hash_table(__hash_table&& __u) ^ <..> In file included from lobster_impl.cpp:2: In file included from ../lobster/src/lobster/stdafx.h:84: ../lobster/src/lobster/tools.h:714:25: error: unknown type name 'string_view'; did you mean 'std::experimental::string_view'? inline string operator+(string_view a, string_view b) { ^~~~~~~~~~~ std::experimental::string_view /usr/include/c++/v1/experimental/string_view:777:39: note: 'std::experimental::string_view' declared here typedef basic_string_view<char> string_view; ^ In file included from lobster_impl.cpp:2: In file included from ../lobster/src/lobster/stdafx.h:84: ../lobster/src/lobster/tools.h:714:40: error: unknown type name 'string_view'; did you mean 'std::experimental::string_view'? inline string operator+(string_view a, string_view b) { ^~~~~~~~~~~ std::experimental::string_view /usr/include/c++/v1/experimental/string_view:777:39: note: 'std::experimental::string_view' declared here typedef basic_string_view<char> string_view; ^ <..> % make MAKE_JOBS_UNSAFE=yes <..> In file included from main.cpp:2: ./stdafx.h:73:10: fatal error: 'string_view' file not found #include <string_view> ^~~~~~~~~~~~~ 1 error generated. <..> -->8-
Committed, thanks!
A commit references this bug: Author: swills Date: Tue Oct 9 13:52:06 UTC 2018 New revision: 481634 URL: https://svnweb.freebsd.org/changeset/ports/481634 Log: deskutils/treesheets: Update to 1.0.1 PR: 232109 Submitted by: lightside <lightside@gmx.com> (maintianer) Changes: head/deskutils/treesheets/Makefile head/deskutils/treesheets/distinfo