Bug 232189 - [NEW PORT] mail/s-nail: Send and receive Internet mail
Summary: [NEW PORT] mail/s-nail: Send and receive Internet mail
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Koichiro Iwao
URL:
Keywords: feature, needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2018-10-11 23:22 UTC by Yasuhiro Kimura
Modified: 2018-12-27 08:13 UTC (History)
4 users (show)

See Also:

Attachments
patch file (3.16 KB, patch)
2018-10-11 23:22 UTC, Yasuhiro Kimura 		no flags Details | Diff
updated patch file (3.14 KB, patch)
2018-10-25 13:46 UTC, Yasuhiro Kimura 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yasuhiro Kimura freebsd_committer freebsd_triage 2018-10-11 23:22:06 UTC 
Created attachment 198047 [details]
patch file

S-nail provides a simple and friendly environment for sending and receiving mail. It is intended to provide the functionality of the POSIX mailx(1) command, but is MIME capable and optionally offers extensions for line editing, S/MIME, SMTP and POP3, among others. S-nail divides incoming mail into its constituent messages and allows the user to deal with them in any order. It offers many COMMANDS and INTERNAL VARIABLES for manipulating messages and sending mail. It provides the user simple editing capabilities to ease the composition of outgoing messages, and increasingly powerful and reliable non-interactive scripting capabilities.
Comment 1 Nathan 2018-10-16 03:34:03 UTC 
Comment on attachment 198047 [details]
patch file

+.for f in ${PORTDOCS}
+	${INSTALL_DATA} ${WRKSRC}/${f} ${STAGEDIR}${DOCSDIR}
+.endfor

No need of for statement when you can do:
(cd ${WRKSRC} && ${INSTALL_DATA} NEWS README ${STAGEDIR}${DOCSDIR})
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2018-10-17 04:56:47 UTC 
Comment on attachment 198047 [details]
patch file

Approval only required/needed/applies to existing (committed) ports
Comment 3 Yasuhiro Kimura freebsd_committer freebsd_triage 2018-10-25 13:46:39 UTC 
Created attachment 198619 [details]
updated patch file

Update patch not to use .for ... .endfor loop.
So please commit attached patch instead of original one.
Comment 4 Koichiro Iwao freebsd_committer freebsd_triage 2018-12-27 04:24:50 UTC 
Take.
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-12-27 08:11:09 UTC 
A commit references this bug:

Author: meta
Date: Thu Dec 27 08:10:33 UTC 2018
New revision: 488512
URL: https://svnweb.freebsd.org/changeset/ports/488512

Log:
  New port: mail/s-nail

  S-nail provides a simple and friendly environment for sending and
  receiving mail. It is intended to provide the functionality of the
  POSIX mailx(1) command, but is MIME capable and optionally offers
  extensions for line editing, S/MIME, SMTP and POP3, among others.
  S-nail divides incoming mail into its constituent messages and allows
  the user to deal with them in any order. It offers many COMMANDS and
  INTERNAL VARIABLES for manipulating messages and sending mail. It
  provides the user simple editing capabilities to ease the composition
  of outgoing messages, and increasingly powerful and reliable
  non-interactive scripting capabilities.

  WWW: https://www.sdaoden.eu/code.html#s-mailx

  PR:		232189
  Submitted by:	Yasuhiro KIMURA <yasu@utahime.org>
  Approved by:	mentors (implicit)

Changes:
  head/mail/Makefile
  head/mail/s-nail/
  head/mail/s-nail/Makefile
  head/mail/s-nail/distinfo
  head/mail/s-nail/pkg-descr
Comment 6 Koichiro Iwao freebsd_committer freebsd_triage 2018-12-27 08:12:55 UTC 
Works fine for me. When pkg-plist contains few files, PLIST_FILES is prefered.
Committed with minor changes, thanks!