Bug 232200 - textproc/augeas: Fix syslog.conf parsing.
Summary: textproc/augeas: Fix syslog.conf parsing.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: FreeBSD Puppet Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-12 09:05 UTC by Mathieu Arnold
Modified: 2018-10-25 13:52 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (puppet)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Arnold freebsd_committer freebsd_triage 2018-10-12 09:05:13 UTC 
It would be great if this patch could make it in the port, it fixes syslog.conf parsing:

https://github.com/lutter/augeas/commit/12c38cb20ef8bade8656cd907298adb972eacb1b
Comment 1 Romain Tartière freebsd_committer freebsd_triage 2018-10-12 09:38:12 UTC 
Seems legit!
Comment 2 Romain Tartière freebsd_committer freebsd_triage 2018-10-12 10:00:57 UTC 
We are trying to work with upstream to make this easy for us to maintain.

https://github.com/hercules-team/augeas/pull/521#issuecomment-429271980
Comment 3 Romain Tartière freebsd_committer freebsd_triage 2018-10-19 08:53:09 UTC 
The change was merged upstream \o/

If you are actively using this, we can backport this into the port, otherwise the next release should contain the change.
Comment 4 Mathieu Arnold freebsd_committer freebsd_triage 2018-10-25 12:40:29 UTC 
Well, if I took the time to find a patch and open a PR, it is because I am using it and it is breaking stuff for me.  This has been open for almost two weeks, I will probably commit it tomorrow with maintainer timeout.
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-10-25 13:51:54 UTC 
A commit references this bug:

Author: romain
Date: Thu Oct 25 13:51:50 UTC 2018
New revision: 482971
URL: https://svnweb.freebsd.org/changeset/ports/482971

Log:
  Fix syslog.conf parsing

  Backport change merged upstream until a new release of augeas happens.
  While here, pet portlint.

  PR:		232200
  Reported by:	mat

Changes:
  head/textproc/augeas/Makefile
  head/textproc/augeas/files/patch-lenses_syslog.aug
  head/textproc/augeas/files/patch-lenses_tests_test__syslog.aug
  head/textproc/augeas/files/patch-tests_root_etc_syslog.conf