Bug 232283 - x11/cool-retro-term: fix build on GCC-based architectures
Summary: x11/cool-retro-term: fix build on GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexey Dokuchaev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-15 13:08 UTC by Piotr Kubaj
Modified: 2018-11-21 15:45 UTC (History)
3 users (show)

See Also:
danfe: maintainer-feedback+

Attachments
patch (313 bytes, patch)
2018-10-15 13:08 UTC, Piotr Kubaj 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2018-10-15 13:08:10 UTC 
Created attachment 198174 [details]
patch

The check to use GCC in port's Makefile is incomplete. GCC needs to be used also on other POWER architectures, on mips (currently new GCC needs to be ported to mips*) and sparc64.

Tested on powerpc64.

Hardware sponsored by IntegriCloud.
Comment 1 Alexey Dokuchaev freebsd_committer freebsd_triage 2018-10-25 07:56:09 UTC 
Looks OK, go ahead.
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-11-21 14:22:39 UTC 
A commit references this bug:

Author: linimon
Date: Wed Nov 21 14:22:00 UTC 2018
New revision: 485517
URL: https://svnweb.freebsd.org/changeset/ports/485517

Log:
  Fix build on GCC-based architectures with USE_GCC correctly gated.

  PR:		232283
  Submitted by:	Piotr Kubaj
  Approved by:	maintainer

Changes:
  head/x11/cool-retro-term/Makefile
Comment 3 Jan Beich freebsd_committer freebsd_triage 2018-11-21 15:45:22 UTC 
Why not convert to USES=compiler:c++11-lang? For one, mips64 may switch to Clang in future.