Bug 232330 - [NEW PORT] www/chrome-gnome-shell: GNOME Shell integration for Chrome
Summary: [NEW PORT] www/chrome-gnome-shell: GNOME Shell integration for Chrome
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Steve Wills
URL: https://reviews.freebsd.org/D18416
Keywords: feature, needs-qa
Depends on:
Blocks:
 
Reported: 2018-10-16 20:33 UTC by Daniel Shafer
Modified: 2019-07-17 18:47 UTC (History)
5 users (show)

See Also:

Attachments
chrome-gnome-shell.diff (6.00 KB, patch)
2018-10-16 20:33 UTC, Daniel Shafer 		no flags Details | Diff
Updated chrome-gnome-shell.diff (5.91 KB, patch)
2018-10-17 17:59 UTC, Daniel Shafer 		no flags Details | Diff
updated www/chrome-gnome-shell port diff (3.41 KB, patch)
2018-12-03 09:50 UTC, Daniel Shafer 		no flags Details | Diff
www/chrome-gnome-shell-10.1 (3.40 KB, patch)
2019-02-03 21:59 UTC, Daniel Shafer 		daniel: maintainer-approval+
Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Shafer 2018-10-16 20:33:43 UTC 
Created attachment 198236 [details]
chrome-gnome-shell.diff

Browser integration for Gnome Shell
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2018-10-17 04:55:06 UTC 
Reporter indicates (via IRC) that Koop is OK with this being assigned to them
Comment 2 Nathan 2018-10-17 05:05:33 UTC 
Comment on attachment 198236 [details]
chrome-gnome-shell.diff

+GH_ACCOUNT=     Gnome
+USE_GNOME=      pygobject3
+USE_GITHUB=     yes

USE_GITHUB goes before GH_ACCOUNT

Also shouldn't need 
.include <bsd.port.options.mk>
As you are not using .if statements pertaining to port options
Comment 3 Ting-Wei Lan 2018-10-17 13:21:57 UTC 
Comment on attachment 198236 [details]
chrome-gnome-shell.diff

>+GH_ACCOUNT=     Gnome
>+USE_GNOME=      pygobject3
>+USE_GITHUB=     yes

GNOME uses its own GitLab instance (gitlab.gnome.org) instead of GitHub, so I think it is usually discouraged to use USE_GITHUB in GNOME ports because users may wrongly assume the project is maintained on GitHub and file issues or pull requests there, which are likely to be ignored for months or even years. There are USE_GITLAB and GL_SITE which you can use, but in this case there is a better option. Since you are packaging a stable release, you can simply use the release tarball on GNOME download site: https://download.gnome.org/sources/chrome-gnome-shell/.
Comment 4 Daniel Shafer 2018-10-17 17:59:28 UTC 
Created attachment 198281 [details]
Updated chrome-gnome-shell.diff

Changed GitHub to Gnome Master Site
Removed options include
Updated to use tar:xz
Comment 5 Daniel Shafer 2018-12-03 09:49:59 UTC 
Rewiew URL: https://reviews.freebsd.org/D18416
Comment 6 Daniel Shafer 2018-12-03 09:50:49 UTC 
Created attachment 199788 [details]
updated www/chrome-gnome-shell port diff

Cleaned up the port, as I learned over the past few weeks better techniques.
Comment 7 Daniel Shafer 2019-02-03 21:59:22 UTC 
Created attachment 201699 [details]
www/chrome-gnome-shell-10.1

Removed outsource from cmake as the default behavior changed recently.
Comment 8 commit-hook freebsd_committer freebsd_triage 2019-07-17 18:47:10 UTC 
A commit references this bug:

Author: swills
Date: Wed Jul 17 18:46:17 UTC 2019
New revision: 506811
URL: https://svnweb.freebsd.org/changeset/ports/506811

Log:
  www/chrome-gnome-shell: create port

  Native host messaging connector that provides integration
  with GNOME Shell and the corresponding extensions repository
  https://extensions.gnome.org

  WWW: https://wiki.gnome.org/Projects/GnomeShellIntegrationForChrome

  PR:		232330
  Submitted by:	Daniel Shafer <daniel@shafer.cc>

Changes:
  head/www/Makefile
  head/www/chrome-gnome-shell/
  head/www/chrome-gnome-shell/Makefile
  head/www/chrome-gnome-shell/distinfo
  head/www/chrome-gnome-shell/pkg-descr
  head/www/chrome-gnome-shell/pkg-message
  head/www/chrome-gnome-shell/pkg-plist
Comment 9 Steve Wills freebsd_committer freebsd_triage 2019-07-17 18:47:23 UTC 
Committed, thanks!