Bug 232381 - graphics/freeimage: fix build on GCC-based architectures
Summary: graphics/freeimage: fix build on GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mark Linimon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-18 13:12 UTC by Piotr Kubaj
Modified: 2018-11-24 09:19 UTC (History)
1 user (show)

See Also:

Attachments
patch (2.06 KB, patch)
2018-10-18 13:12 UTC, Piotr Kubaj 		no flags Details | Diff
v2 (1.48 KB, patch)
2018-11-18 16:24 UTC, Piotr Kubaj 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2018-10-18 13:12:03 UTC 
Created attachment 198298 [details]
patch

Code for big-endian architectures is outdated, causing build failures on big-endian architectures.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-10-28 11:26:28 UTC 
A commit references this bug:

Author: linimon
Date: Sun Oct 28 11:26:06 UTC 2018
New revision: 483279
URL: https://svnweb.freebsd.org/changeset/ports/483279

Log:
  Fix build on GCC-based architectures.

  PR:		232381
  Submitted by:	Piotr Kubaj

Changes:
  head/graphics/freeimage/Makefile
  head/graphics/freeimage/files/patch-Source_FreeImage_PluginBMP.cpp
Comment 2 Piotr Kubaj freebsd_committer freebsd_triage 2018-11-18 16:24:01 UTC 
Created attachment 199317 [details]
v2

It looks like I forgot to svn add this patch. Could you commit it?

Some code for big-endian architectures is obsolete.
Comment 3 Piotr Kubaj freebsd_committer freebsd_triage 2018-11-18 16:24:31 UTC 
Opening.
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-11-24 09:19:41 UTC 
A commit references this bug:

Author: linimon
Date: Sat Nov 24 09:19:36 UTC 2018
New revision: 485740
URL: https://svnweb.freebsd.org/changeset/ports/485740

Log:
  Add patch forgotten in previous commit.  Some code for big-endian
  architectures is obsolete.

  PR:		232381
  Submitted by:	Piotr Kubaj

Changes:
  head/graphics/freeimage/files/patch-Source_FreeImage_PluginDDS.cpp