Bug 232440 - sysutils/google-compute-engine-oslogin: update to 1.3.1
Summary: sysutils/google-compute-engine-oslogin: update to 1.3.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Steve Wills
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2018-10-19 10:47 UTC by Lucas Kanashiro
Modified: 2018-11-23 19:49 UTC (History)
2 users (show)

See Also:
helen.koike: maintainer-feedback+


Attachments
Patch sysutils/google-compute-engine-oslogin to version 1.3.1 (4.42 KB, patch)
2018-10-19 10:47 UTC, Lucas Kanashiro
no flags Details | Diff
Poudriere logs (4.25 KB, application/gzip)
2018-10-19 10:51 UTC, Lucas Kanashiro
no flags Details
Patch sysutils/google-compute-engine-oslogin to version 1.3.1 (4.41 KB, patch)
2018-10-19 13:37 UTC, Lucas Kanashiro
no flags Details | Diff
Updated patch sysutils/google-compute-engine-oslogin to version 1.3.1 (4.39 KB, patch)
2018-10-30 09:46 UTC, Lucas Kanashiro
no flags Details | Diff
Fix portlint warnings (11.18 KB, patch)
2018-11-12 17:55 UTC, Lucas Kanashiro
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Kanashiro 2018-10-19 10:47:44 UTC
Created attachment 198356 [details]
Patch sysutils/google-compute-engine-oslogin to version 1.3.1

Update to the latest upstream version (aka 1.3.1) to make new features available for GCE cloud images.

The file files/patch-Makefile was removed since this modification was applied by upstream in this latest version.
Comment 1 Lucas Kanashiro 2018-10-19 10:51:12 UTC
Created attachment 198357 [details]
Poudriere logs
Comment 2 Lucas Kanashiro 2018-10-19 13:37:56 UTC
Created attachment 198361 [details]
Patch sysutils/google-compute-engine-oslogin to version 1.3.1

Updating patch.
Comment 3 Helen Koike 2018-10-19 13:40:08 UTC
Comment on attachment 198361 [details]
Patch sysutils/google-compute-engine-oslogin to version 1.3.1

Thanks for the patch!
Comment 4 Lucas Kanashiro 2018-10-30 09:46:23 UTC
Created attachment 198766 [details]
Updated patch sysutils/google-compute-engine-oslogin to version 1.3.1

Remove PORTREVISION.
Comment 5 Steve Wills freebsd_committer freebsd_triage 2018-11-10 15:25:21 UTC
portlint -C reports:

WARN: /usr/local/poudriere/ports/default/sysutils/google-compute-engine-oslogin/pkg-descr: includes lines that exceed 80 characters.
WARN: Makefile: extra item placed in the USES/USE_x section, for example, "MAKE_ARGS".        
WARN: /usr/local/poudriere/ports/default/sysutils/google-compute-engine-oslogin/files/patch-utils_oslogin__utils.cc: patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.   
0 fatal errors and 3 warnings found.
Comment 6 Lucas Kanashiro 2018-11-12 17:55:12 UTC
Created attachment 199181 [details]
Fix portlint warnings

Most of the warnings reported by portlint were fixed:

$ portlint -C
WARN: /usr/home/kanashiro/google-compute-engine-oslogin/pkg-descr: includes lines that exceed 80 characters.
0 fatal errors and 1 warning found.


Only the above one was not fixed because it is an URL and does not make sense break it to satisfy portlint.
Comment 7 commit-hook freebsd_committer freebsd_triage 2018-11-23 19:43:58 UTC
A commit references this bug:

Author: swills
Date: Fri Nov 23 19:43:46 UTC 2018
New revision: 485700
URL: https://svnweb.freebsd.org/changeset/ports/485700

Log:
  sysutils/google-compute-engine-oslogin: update to 1.3.1

  PR:		232440
  Submitted by:	Lucas Kanashiro <lucas.kanashiro@collabora.com>
  Approved by:	Helen Koike <helen.koike@collabora.com> (maintainer, earlier version of patch)

Changes:
  head/sysutils/google-compute-engine-oslogin/Makefile
  head/sysutils/google-compute-engine-oslogin/distinfo
  head/sysutils/google-compute-engine-oslogin/files/patch-Makefile
  head/sysutils/google-compute-engine-oslogin/files/patch-bin_google__oslogin__control
  head/sysutils/google-compute-engine-oslogin/files/patch-libnss__cache__oslogin_nss__cache__oslogin.c
  head/sysutils/google-compute-engine-oslogin/files/patch-nss__cache_nss__cache.cc
  head/sysutils/google-compute-engine-oslogin/files/patch-nss__module_nss__oslogin.cc
  head/sysutils/google-compute-engine-oslogin/files/patch-pam__module_pam__oslogin__admin.cc
  head/sysutils/google-compute-engine-oslogin/files/patch-pam__module_pam__oslogin__login.cc
  head/sysutils/google-compute-engine-oslogin/files/patch-utils_oslogin__utils.cc
Comment 8 Steve Wills freebsd_committer freebsd_triage 2018-11-23 19:49:23 UTC
(In reply to Lucas Kanashiro from comment #6)
Thanks, committed. Made a slight change so that the patch didn't have "/usr/local/usr/local" in it and also so that changing PREFIX works. Sorry it took me so long to get back to this.