Bug 232513 - devel/psptoolchain-binutils: fix build on powerpc64
Summary: devel/psptoolchain-binutils: fix build on powerpc64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mark Linimon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-21 21:24 UTC by Piotr Kubaj
Modified: 2018-11-24 08:53 UTC (History)
2 users (show)

See Also:
tphilipp: maintainer-feedback-

Attachments
patch (548 bytes, patch)
2018-10-21 21:24 UTC, Piotr Kubaj 		no flags Details | Diff
v2 (1.08 KB, patch)
2018-10-23 15:00 UTC, Piotr Kubaj 		no flags Details | Diff
v3 (719 bytes, patch)
2018-10-24 14:27 UTC, Piotr Kubaj 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2018-10-21 21:24:18 UTC 
Created attachment 198449 [details]
patch

This port builds just fine with no extra patches.

Tested on powerpc64.

Hardware sponsored by IntegriCloud.
Comment 1 Piotr Kubaj freebsd_committer freebsd_triage 2018-10-23 15:00:29 UTC 
Created attachment 198500 [details]
v2

Additional fix is needed. The downside is that other architectures need to be fixed separately.
Comment 2 Tassilo Philipp 2018-10-24 10:52:44 UTC 
Hi, thanks for reporting. However, there are multiple issues here:

- patch 'v2' won't work on other FreeBSD versions than 12.0, because the arguments to the 'mv' in your patch are version specific

- also, this second patch ('v2') assumes the first is already applied, however you removed the first

Also, I'm afraid I don't understand what you mean with "This port builds just fine with no extra patches."?
Comment 3 Tassilo Philipp 2018-10-24 11:09:39 UTC 
Also, two more questions:

- I don't think that the proposed patch fixes the root cause of the problem, can you explain what the idea behind this fix is?

- you said you "Tested on powerpc64.", so are you sure the port is broken on arm64 and mips64, as your first patch suggests?
Comment 4 Piotr Kubaj freebsd_committer freebsd_triage 2018-10-24 14:27:30 UTC 
Created attachment 198556 [details]
v3

Sorry, you're right.

I didn't notice that CONFIGURE_TARGET needed to be changed and I think this patch now properly fixes this issue.

Other architectures can also be fixed this way.
Comment 5 Piotr Kubaj freebsd_committer freebsd_triage 2018-10-24 14:29:23 UTC 
(In reply to Tassilo Philipp from comment #3)
1. The problem is that files are put in /usr/local/powerpc-unknown-freebsd12.0, but CONFIGURE_TARGET was powerpc64-unknown-freebsd12.0. That needed to be changed.

2. I'm not sure, but BROKEN message suggests it.
Comment 6 Tassilo Philipp 2018-10-25 11:07:42 UTC 
Thanks, that looks good. Give me a few days and I'll see whether I can extend it to mips64 and arm64 (I can actually test those), and give it some other tests.
:)
Comment 7 Tassilo Philipp 2018-10-25 11:25:07 UTC 
@linimon hi, can you assign this to me, so I can eventually set the maintainer-approval+ flag?
Comment 8 Tassilo Philipp 2018-10-25 11:30:30 UTC 
(In reply to Tassilo Philipp from comment #7)

sorry, nm, I spaced that this flag is per attachment, sorry
Comment 9 commit-hook freebsd_committer freebsd_triage 2018-11-24 08:53:11 UTC 
A commit references this bug:

Author: linimon
Date: Sat Nov 24 08:52:36 UTC 2018
New revision: 485733
URL: https://svnweb.freebsd.org/changeset/ports/485733

Log:
  Change powerpc64 to powerpc in CONFIGURE_TARGET to fix build on
  powerpc64.

  PR:		232513
  Submitted by:	Piotr Kubaj
  Approved by:	portmgr (tier-2 blanket)

Changes:
  head/devel/psptoolchain-binutils/Makefile