Bug 232586 - graphics/gnome-color-manager: fix build with GCC-based architectures
Summary: graphics/gnome-color-manager: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-24 00:20 UTC by Piotr Kubaj
Modified: 2018-11-27 16:01 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (gnome)

Attachments
patch (370 bytes, patch)
2018-10-24 00:20 UTC, Piotr Kubaj 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2018-10-24 00:20:39 UTC 
Created attachment 198527 [details]
patch

This port needs USES=compiler:c++11-lang to build on GCC architectures.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 Ting-Wei Lan 2018-10-24 14:02:45 UTC 
gnome-color-manager is mostly written in C. It has only one simple C++ source file. Did you mean c11 instead?
Comment 2 Piotr Kubaj freebsd_committer freebsd_triage 2018-10-24 14:12:46 UTC 
There are not many ports that use C11, so I actually meant C++11. That said, it doesn't really matter from the perspective of ports infrastructure. Clang in all releases supports both C++11 and C11, GCC 4.2 supports neither C++11 nor C11 :)

If you feel that it's better to put C11, it's not a problem since both will work the same.
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2018-11-27 15:58:36 UTC 
(In reply to Ting-Wei Lan from comment #1)

Since it does have one c++ file, yes, I think c++11-lang will be necessary.
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-11-27 16:01:06 UTC 
A commit references this bug:

Author: linimon
Date: Tue Nov 27 16:00:48 UTC 2018
New revision: 486015
URL: https://svnweb.freebsd.org/changeset/ports/486015

Log:
  Add USES=compiler:c++11-lang to build on GCC architectures.

  PR:		232586
  Submitted by:	Piotr Kubaj
  Approved by:	portmgr (tier-2 blanket)

Changes:
  head/graphics/gnome-color-manager/Makefile