Bug 232593 - science/kalzium-kde4: Fix build
Summary: science/kalzium-kde4: Fix build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-kde (group)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-24 05:40 UTC by Yuri Victorovich
Modified: 2018-10-28 02:38 UTC (History)
1 user (show)

See Also:
tcberner: maintainer-feedback+

Attachments
patch (5.04 KB, patch)
2018-10-24 05:40 UTC, Yuri Victorovich 		no flags Details | Diff
patch (7.06 KB, patch)
2018-10-24 20:00 UTC, Yuri Victorovich 		tcberner: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2018-10-24 05:40:54 UTC 
Created attachment 198531 [details]
patch
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2018-10-24 06:07:04 UTC 
No, it still breaks for other reasons. Please hold on.
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2018-10-24 06:16:50 UTC 
Tobias,

There is some conflict in the use of Eigen.

I suggest to just mark it as BROKEN, since it isn't worth the time to investigate old, discontinued version breakages.

This is the EOLed version of kalzium, that also uses the older version of avogadro libs. Users who want to use kalzium really need to switch to the currently supported version.


Yuri
Comment 3 Tobias C. Berner freebsd_committer freebsd_triage 2018-10-24 19:22:40 UTC 
Hi Yuri

Thanks for investigating. I'm not convinced this is ideal. The port will be deleted anyways in december. However, I think it is worth investigating whether using eigen:3 in avogadro would be feasible. 

Also science/kalzium seems to still build, so there might be some changes in that version that can be backported to kalzium-kde4 [though I agree, that investing time in EOL software is not the best investment of time -- but as we broke it by upgrading its dependency, we need to fix it, or revert the upgrade].


mfg Tobias
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2018-10-24 19:42:31 UTC 
(In reply to Tobias C. Berner from comment #3)

Tobias,

Ok, I will look into this some more.

Yuri
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2018-10-24 20:00:43 UTC 
Created attachment 198599 [details]
patch

Disabling Eigen3 detection does the trick. -)

The port says eigen:2, but eigen3 detection is actually in place, and it fails with eigen3 when detected.

For whatever reason, the plist lost 3 files, but at least it builds now. -)
Comment 6 Tobias C. Berner freebsd_committer freebsd_triage 2018-10-27 19:56:47 UTC 
Comment on attachment 198599 [details]
patch

Hi Yuri,

Thanks for fixing it.

You could probably be a bit more elegant by disabling it via CMAKE_DISABLE_FIND_PACKAGE_Eigen3, but I think this is good enough for the 2 months until svn rm :D 

Please feel free to commit it, and refer to r482622.


mfg Tobias
Comment 7 Yuri Victorovich freebsd_committer freebsd_triage 2018-10-28 02:37:48 UTC 
Thanks, Tobias!
Comment 8 commit-hook freebsd_committer freebsd_triage 2018-10-28 02:38:28 UTC 
A commit references this bug:

Author: yuri
Date: Sun Oct 28 02:37:34 UTC 2018
New revision: 483212
URL: https://svnweb.freebsd.org/changeset/ports/483212

Log:
  science/kalzium-kde4: Fix build

  * Fix variable/macro name clash
  * Fix broken eigen:3 recognition by disablijng it

  PR:		232593

Changes:
  head/science/kalzium-kde4/Makefile
  head/science/kalzium-kde4/files/
  head/science/kalzium-kde4/files/patch-src_calculator_gasCalculator.cpp
  head/science/kalzium-kde4/files/patch-src_calculator_gasCalculator.h
  head/science/kalzium-kde4/pkg-plist