Bug 232608 - devel/libdbusmenu: fix build with GCC-based architectures
Summary: devel/libdbusmenu: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mark Linimon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-24 12:33 UTC by Piotr Kubaj
Modified: 2018-12-06 23:40 UTC (History)
1 user (show)

See Also:

Attachments
patch (823 bytes, patch)
2018-10-24 12:33 UTC, Piotr Kubaj 		no flags Details | Diff
updated patch to Makefile (712 bytes, patch)
2018-12-06 14:48 UTC, Mark Linimon 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2018-10-24 12:33:08 UTC 
Created attachment 198546 [details]
patch

Needs -Wno-unused-value to build with base GCC.

While here, add USES=gnome.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2018-11-18 17:47:58 UTC 
Take.  Per the mailing lists the patch needs further work.
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2018-12-06 14:48:03 UTC 
Created attachment 199897 [details]
updated patch to Makefile
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2018-12-06 15:13:27 UTC 
Of course the conditional should be

.if ${CHOSEN_COMPILER_TYPE} == gcc
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-12-06 23:40:54 UTC 
A commit references this bug:

Author: linimon
Date: Thu Dec  6 23:40:16 UTC 2018
New revision: 486809
URL: https://svnweb.freebsd.org/changeset/ports/486809

Log:
  -Wno-unused-value is needed to build with base GCC.

  While here, add USES=gnome.

  PR:		232608
  Submitted by:	Piotr Kubaj

Changes:
  head/devel/libdbusmenu/Makefile