Bug 232734 - devel/astyle: fix build with GCC-based architectures
Summary: devel/astyle: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Lars Engels
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-27 00:26 UTC by Piotr Kubaj
Modified: 2019-01-02 09:17 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (lme)

Attachments
patch (2.49 KB, patch)
2018-10-27 00:26 UTC, Piotr Kubaj 		no flags Details | Diff
v2 (1.70 KB, patch)
2018-11-28 00:36 UTC, Piotr Kubaj 		no flags Details | Diff
updated patches to devel/astyle (779 bytes, patch)
2018-12-31 06:25 UTC, Mark Linimon 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2018-10-27 00:26:54 UTC 
Created attachment 198684 [details]
patch

Fix CXX assignment and add new includes to fix build on GCC architectures.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2018-11-24 08:15:43 UTC 
I still get a build failure:

cc1plus: error: unrecognized command line option "-std=c++11"
Comment 2 Piotr Kubaj freebsd_committer freebsd_triage 2018-11-28 00:36:28 UTC 
Created attachment 199623 [details]
v2

You're right, can you try this patch?
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2018-12-31 06:25:32 UTC 
Created attachment 200644 [details]
updated patches to devel/astyle

v2 still fails for me on amd64.  I am now trying the above patch.
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2019-01-01 15:19:48 UTC 
(In reply to Mark Linimon from comment #3)

Of course my updated patch dropped the files/* component.  I am re-testing.
Comment 5 commit-hook freebsd_committer freebsd_triage 2019-01-02 09:10:02 UTC 
A commit references this bug:

Author: linimon
Date: Wed Jan  2 09:09:51 UTC 2019
New revision: 489067
URL: https://svnweb.freebsd.org/changeset/ports/489067

Log:
  Fix CXX assignment and add new includes to fix build on GCC-based
  architectures.

  PR:		232734
  Submitted by:	Piotr Kubaj
  Approved by:	portmgr (tier-2 blanket)

Changes:
  head/devel/astyle/Makefile
  head/devel/astyle/files/
  head/devel/astyle/files/patch-build_gcc_Makefile
  head/devel/astyle/files/patch-src_astyle__main.cpp
Comment 6 commit-hook freebsd_committer freebsd_triage 2019-01-02 09:17:10 UTC 
A commit references this bug:

Author: linimon
Date: Wed Jan  2 09:16:19 UTC 2019
New revision: 489068
URL: https://svnweb.freebsd.org/changeset/ports/489068

Log:
  MFH: r489067

  Fix CXX assignment and add new includes to fix build on GCC-based
  architectures.

  PR:		232734
  Submitted by:	Piotr Kubaj
  Approved by:	portmgr (tier-2 blanket)

  Approved by:	portmgr (tier-2 blanket)

Changes:
_U  branches/2019Q1/
  branches/2019Q1/devel/astyle/Makefile
  branches/2019Q1/devel/astyle/files/