Bug 232822 - multimedia/mkvtoolnix: fix build with GCC-based architectures
Summary: multimedia/mkvtoolnix: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thomas Zander
URL:
Keywords: needs-qa, patch
Depends on: 232820 232821
Blocks:
  Show dependency tree / graph
 
Reported: 2018-10-30 18:09 UTC by Piotr Kubaj
Modified: 2018-11-24 12:05 UTC (History)
2 users (show)

See Also:
riggs: maintainer-feedback+

Attachments
patch (482 bytes, patch)
2018-10-30 18:09 UTC, Piotr Kubaj 		no flags Details | Diff
Set USE_CXXSTD only if clang is not used (1.02 KB, patch)
2018-11-04 13:15 UTC, Thomas Zander 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2018-10-30 18:09:08 UTC 
Created attachment 198780 [details]
patch

We need to define USES=compiler:c++17-lang and USE_CXXSTD=c++17 to fix those errors when building with GCC:
src/merge/mkvmerge.o:(.toc+0x10): undefined reference to `boost::system::detail::generic_category_instance'
src/merge/mkvmerge.o:(.toc+0x18): undefined reference to `boost::system::detail::generic_category_instance'
src/common/libmtxcommon.a(logger.o):(.toc+0x20): undefined reference to `boost::system::detail::system_category_instance'
src/common/libmtxcommon.a(common.o):(.toc+0x18): undefined reference to `boost::system::detail::system_category_instance'

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 Thomas Zander freebsd_committer freebsd_triage 2018-11-03 12:41:40 UTC 
Thanks!

Sadly, this breaks the build on 10.4, which is EOL'd, I know but please allow for some more investigation on my side before I commit this.
Comment 2 Thomas Zander freebsd_committer freebsd_triage 2018-11-04 13:15:23 UTC 
Created attachment 198940 [details]
Set USE_CXXSTD only if clang is not used

Piotr, could you confirm that this works?
Comment 3 Thomas Zander freebsd_committer freebsd_triage 2018-11-17 04:35:58 UTC 
(In reply to Thomas Zander from comment #2)

Ping
Comment 4 Mark Linimon freebsd_committer freebsd_triage 2018-11-24 10:16:33 UTC 
I can confirm that this builds both on powerpc64 and amd64.
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-11-24 12:01:53 UTC 
A commit references this bug:

Author: riggs
Date: Sat Nov 24 12:00:57 UTC 2018
New revision: 485765
URL: https://svnweb.freebsd.org/changeset/ports/485765

Log:
  Fix build on GCC-based architectures

  PR:		232822
  Submitted by:	pkubaj@anongoth.pl
  Reviewed by:	riggs, linimon

Changes:
  head/multimedia/mkvtoolnix/Makefile