Bug 232876 - science/voro++: Build shared library
Summary: science/voro++: Build shared library
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jason W. Bacon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-01 04:09 UTC by Yuri Victorovich
Modified: 2018-11-04 15:53 UTC (History)
1 user (show)

See Also:
tobik: maintainer-feedback? (jwb)

Attachments
patch (8.02 KB, patch)
2018-11-01 04:09 UTC, Yuri Victorovich 		tobik: maintainer-approval? (jwb)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2018-11-01 04:09:51 UTC 
Created attachment 198836 [details]
patch

Change static libary to shared library.

Reason: It is easier to see if the dependent project is linked with a shared library vs. static library. Most library dependencies are through LIB_DEPENDS. For static library it is BUILD_DEPENDS. It is easier to keep all of them the same way. It is also better to not duplicate code, when every user has to include the full static library library.

Also simplified the Makefile.
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2018-11-01 08:03:27 UTC 
Inviting maintainer to the PR.
Comment 2 Jason W. Bacon freebsd_committer freebsd_triage 2018-11-04 15:01:03 UTC 
Reviewing and testing...
Comment 3 Jason W. Bacon freebsd_committer freebsd_triage 2018-11-04 15:53:14 UTC 
Committed with some changes, thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-11-04 15:53:39 UTC 
A commit references this bug:

Author: jwb
Date: Sun Nov  4 15:52:44 UTC 2018
New revision: 484101
URL: https://svnweb.freebsd.org/changeset/ports/484101

Log:
  science/voro++: Add shared library

  Consolidated build changes into patch files.

  Kept static lib as well as some dependencies may specify it explicitly
  (this is common in scientific software for better or worse) and the library
  is very small.

  PR:             232876
  Reported by:    yuri
  Approved by:    jrm (mentor, implicit)

Changes:
  head/science/voro++/Makefile
  head/science/voro++/files/
  head/science/voro++/files/patch-Makefile
  head/science/voro++/files/patch-config.mk
  head/science/voro++/files/patch-src_Makefile
  head/science/voro++/pkg-descr
  head/science/voro++/pkg-plist