Bug 233057 - emulators/rtc: Fix build with stable/12
Summary: emulators/rtc: Fix build with stable/12
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-07 12:08 UTC by Oleg Sidorkin
Modified: 2020-09-01 09:05 UTC (History)
2 users (show)

See Also:
pi: maintainer-feedback-

Attachments
patch to allow emulators/rtc to be built on stable/12 (2.77 KB, patch)
2018-11-07 12:08 UTC, Oleg Sidorkin 		no flags Details | Diff
patch to clean up emulators/rtc port (12.39 KB, patch)
2020-07-09 00:22 UTC, Jamie Landeg-Jones 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Sidorkin 2018-11-07 12:08:06 UTC 
Created attachment 199049 [details]
patch to allow emulators/rtc to be built on stable/12

Patch follows r328417 way for MALLOC()/FREE() and adds some workarounds for time api changes.
Comment 1 Jamie Landeg-Jones 2019-01-15 21:38:32 UTC 
Comment on attachment 199049 [details]
patch to allow emulators/rtc to be built on stable/12

*bump*

Please can this be actioned? I'm sure I'm not the only one to have got bitten by this in the last month!
Comment 2 Jamie Landeg-Jones 2020-07-09 00:21:52 UTC 
Tidy up port.

Take ownership.

I've incorporated Olegs patch and made some other changes to this port.

- Take ownership
- Install kmod into /boot/modules instead of /usr/local/....
- Cleared out bits dating back to pre-devfs
- Removed #ifdef bits related to FreeBSD <= 4.X and FreeBSD <= 8.X
- Olegs fixes for FreeBSD 11.X and FreeBSD 12.X+
- Removed "USES= linux uidfix" - whilst this provides functionality that is "often" used by linux programs, that's not necessarily the case, and this module doesn't require any linux subsystem or kernel MOD to operate.
- Removed oldstyle rtc.sh - include pkg-message showing how to load from the rc.conf "kld_list" mechanism.
- Fixed typo in "test.c" -> /dec -> /dev
- Fixed path to "rtc.h" in "test.c"
Comment 3 Jamie Landeg-Jones 2020-07-09 00:22:59 UTC 
Created attachment 216332 [details]
patch to clean up emulators/rtc port
Comment 4 Kurt Jaeger freebsd_committer freebsd_triage 2020-09-01 09:00:49 UTC 
testbuilds@work
Comment 5 commit-hook freebsd_committer freebsd_triage 2020-09-01 09:04:49 UTC 
A commit references this bug:

Author: pi
Date: Tue Sep  1 09:04:34 UTC 2020
New revision: 547249
URL: https://svnweb.freebsd.org/changeset/ports/547249

Log:
  emulators/rtc: update 2004.02.24.1 -> 2020.07.07.1

  - submitter becomes maintainer
  - Install kmod into /boot/modules instead of /usr/local
  - Cleared out bits dating back to pre-devfs
  - Removed #ifdef bits related to FreeBSD <= 4.X and FreeBSD <= 8.X
  - Olegs fixes for FreeBSD 11.X and FreeBSD 12.X+
  - Removed "USES= linux uidfix" - whilst this provides functionality
    that is "often" used by linux programs, that's not necessarily the
    case, and this module doesn't require any linux subsystem or
    kernel MOD to operate.
  - Removed oldstyle rtc.sh - include pkg-message showing how to load
    from the rc.conf "kld_list" mechanism.
  - Fixed typo in "test.c" -> /dec -> /dev
  - Fixed path to "rtc.h" in "test.c"

  PR:		233057
  Submitted by:	Jamie Landeg-Jones <jamie@catflap.org>

Changes:
  head/emulators/rtc/Makefile
  head/emulators/rtc/files/Makefile
  head/emulators/rtc/files/rtc.c
  head/emulators/rtc/files/rtc.sh
  head/emulators/rtc/files/rtc_linux.c
  head/emulators/rtc/files/test.c
  head/emulators/rtc/pkg-message
  head/emulators/rtc/pkg-plist
Comment 6 Kurt Jaeger freebsd_committer freebsd_triage 2020-09-01 09:05:09 UTC 
Committed, thanks!