Bug 233066 - lang/duktape-lib: respect CC
Summary: lang/duktape-lib: respect CC
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Koichiro Iwao
URL:
Keywords:
: 233159 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-11-08 08:50 UTC by Koichiro Iwao
Modified: 2018-11-12 14:58 UTC (History)
2 users (show)

See Also:
asiciliano: maintainer-feedback+

Attachments
patch (1.15 KB, text/plain)
2018-11-08 08:50 UTC, Koichiro Iwao 		meta: maintainer-approval? (asiciliano)
 Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Koichiro Iwao freebsd_committer freebsd_triage 2018-11-08 08:50:45 UTC 
Created attachment 199075 [details]
patch

I noticed patch-Makefile.sharedlibrary is not necessary.
Setting CC=cc is bad for people who want to gcc.
${CC} will be a c compiler that user choose.

https://www.freebsd.org/doc/en/books/porters-handbook/dads-cc.html
Comment 1 Alfonso S. Siciliano freebsd_committer freebsd_triage 2018-11-12 13:24:00 UTC 
Thank you for your suggestion,

I have update the port with the patch bug #233159

Regards
Afonso
Comment 2 Alfonso S. Siciliano freebsd_committer freebsd_triage 2018-11-12 13:25:58 UTC 
You could close the bug,
thanks,
Alfonso
Comment 3 Koichiro Iwao freebsd_committer freebsd_triage 2018-11-12 14:51:35 UTC 
*** Bug 233159 has been marked as a duplicate of this bug. ***
Comment 4 Koichiro Iwao freebsd_committer freebsd_triage 2018-11-12 14:52:17 UTC 
Just approve it.
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-11-12 14:55:11 UTC 
A commit references this bug:

Author: meta
Date: Mon Nov 12 14:54:45 UTC 2018
New revision: 484805
URL: https://svnweb.freebsd.org/changeset/ports/484805

Log:
  lang/duktape-lib: respect CC

  PR:		233066
  Submitted by:	myself
  Approved by:	maintainer, mentors (implicit)

Changes:
  head/lang/duktape-lib/Makefile
  head/lang/duktape-lib/files/