Bug 233084 - net/howl: Fix mdsnresponder rc script parameter expansion default
Summary: net/howl: Fix mdsnresponder rc script parameter expansion default
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Steve Wills
URL:
Keywords: easy, needs-qa
Depends on:
Blocks:
 
Reported: 2018-11-09 08:33 UTC by elij
Modified: 2019-01-27 13:52 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (freebsd)

Attachments
net-howl.diff (335 bytes, patch)
2018-11-09 08:49 UTC, elij 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description elij 2018-11-09 08:33:18 UTC 
missing colon in parameter expansion default.

--- mdnsresponder.old	2018-11-09 00:32:33.977079000 -0800
+++ mdnsresponder	2018-11-09 00:32:42.331257000 -0800
@@ -20,6 +20,6 @@
 
 load_rc_config ${name}
 
-mdnsresponder_enable=${mdnsresponder_enable-"NO"}
+mdnsresponder_enable=${mdnsresponder_enable:-"NO"}
 
 run_rc_command "$1"
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2018-11-09 08:39:50 UTC 
Thank you elij

Could you please provide the change/diff included in comment 0 as an attachment please
Comment 2 elij 2018-11-09 08:49:08 UTC 
Created attachment 199092 [details]
net-howl.diff

sure. added diff/patch file.
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-01-27 13:50:20 UTC 
A commit references this bug:

Author: swills
Date: Sun Jan 27 13:50:11 UTC 2019
New revision: 491350
URL: https://svnweb.freebsd.org/changeset/ports/491350

Log:
  net/howl: Fix mdsnresponder rc script parameter expansion default

  PR:		233084
  Submitted by:	elij <elij+freebsd@wundrd.net>
  Approved by:	maintainer timeout (freebsd@donovansbrain.co.uk, >2 months)

Changes:
  head/net/howl/Makefile
  head/net/howl/files/mdnsresponder.in
Comment 4 Steve Wills freebsd_committer freebsd_triage 2019-01-27 13:52:10 UTC 
Committed, thanks!