Bug 233111 - x11-toolkits/qt5-declarative: fails to build on armv6
Summary: x11-toolkits/qt5-declarative: fails to build on armv6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Only Me
Assignee: freebsd-kde (group)
URL:
Keywords: needs-qa, regression
Depends on:
Blocks: qt5-declarative
  Show dependency tree / graph
 
Reported: 2018-11-10 13:57 UTC by Jan Beich
Modified: 2018-11-10 19:59 UTC (History)
1 user (show)

See Also:
tcberner: maintainer-feedback+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2018-11-10 13:57:08 UTC 
In file included from memory/qv4mm.cpp:49:
In file included from ../3rdparty/masm/wtf/PageReservation.h:29:
In file included from ../3rdparty/masm/wtf/PageAllocation.h:29:
In file included from ../3rdparty/masm/wtf/Assertions.h:45:
../3rdparty/masm/wtf/Platform.h:311:6: error: "Not supported ARM architecture"
#    error "Not supported ARM architecture"
     ^

error log: https://ptpb.pw/XIcz

Previously, it built fine as
http://beefy8.nyi.freebsd.org/data/latest-per-pkg/qt5-qml/5.11.2/head-armv6-default.log
http://beefy8.nyi.freebsd.org/data/latest-per-pkg/qt5-quick/5.11.2/head-armv6-default.log
Comment 1 Tobias C. Berner freebsd_committer freebsd_triage 2018-11-10 14:40:30 UTC 
Ah, I probably forgot to bring the patches from qt5-qml with it...
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-11-10 19:58:14 UTC 
A commit references this bug:

Author: tcberner
Date: Sat Nov 10 19:57:34 UTC 2018
New revision: 484641
URL: https://svnweb.freebsd.org/changeset/ports/484641

Log:
  x11-toolkits/qt5-declarative

  - readd patches for ARM support that got lost in r484140.

  PR:		233111
  Reported by:	jbeich
  Pointy hat:	tcberner

Changes:
  head/x11-toolkits/qt5-declarative/Makefile
  head/x11-toolkits/qt5-declarative/files/patch-src_3rdparty_masm_assembler_ARM64Assembler.h
  head/x11-toolkits/qt5-declarative/files/patch-src_3rdparty_masm_assembler_ARMAssembler.h
  head/x11-toolkits/qt5-declarative/files/patch-src_3rdparty_masm_assembler_ARMv7Assembler.h
  head/x11-toolkits/qt5-declarative/files/patch-src_3rdparty_masm_wtf_Platform.h
Comment 3 Tobias C. Berner freebsd_committer freebsd_triage 2018-11-10 19:59:24 UTC 
Should be fine again.