Created attachment 199202 [details] patch for cmucl-extra There is no changelog because of the nature of the port (collection of utilities). For more information see bug #232011. I have tested successfuly with portlint and poudriere (11.2-RELEASE, amd64 and i386). I have set the license to PD following a suggestion received on IRC, which is consistent with lang/cmucl's license, although many files have their own specific license, different from PD.
Comment on attachment 199202 [details] patch for cmucl-extra +NO_ARCH= yes NO_BUILD= yes +NO_WRKSUBDIR= yes Doesn't belong under options; Nothing goes under OPTIONS, except things such do-install: etc Also check portlint, as I dont think, letters can go into versions; If my memory serves me correct plist doesn't look correct to me
Created attachment 199231 [details] cmucl-extra patch, correction 1 Here is the patch corrected, with some more information. - As for the PORTVERSION with letters, it is allowed. Indeed, I defined DISTVERSION and PORTVERSION was deduced from it. I already checked in bug #232011 that passing from defining PORTVERSION to defining DISTVERSION keeps PORTVERSION increasing. - I fixed the order of variables as requested. - The plist is correct (I checked again with poudriere after I did some change to install the message catalog files in the right directory). It looks funny that it depends on the NLS option although the only instruction in the Makefile dependent on NLS is NLS_USES= gettext, because this line also takes care of installing conditionally the message catalog files. See https://www.freebsd.org/doc/en/books/porters-handbook/using-gettext.html, in particular "The Makefile part of this task is already provided by the idiom". - MASTER_SITES have been changed to the actual official sites for downloading cmucl-extra. - I removed the build dependency on lang/cmucl because this port has NO_BUILD set, so no real build dependencies.
A commit references this bug: Author: swills Date: Sun Jan 6 01:34:52 UTC 2019 New revision: 489430 URL: https://svnweb.freebsd.org/changeset/ports/489430 Log: lang/cmucl-extra: Update to 21.b, clean up While here, assign maintainership to submitter PR: 233195 Submitted by: Lorenzo Salvadore <phascolarctos@protonmail.ch> Changes: head/lang/cmucl-extra/Makefile head/lang/cmucl-extra/distinfo head/lang/cmucl-extra/pkg-plist
Committed, thanks!
A commit references this bug: Author: koobs Date: Mon Jan 7 03:30:26 UTC 2019 New revision: 489556 URL: https://svnweb.freebsd.org/changeset/ports/489556 Log: lang/cmucl{-extra}: Correct maintainer address The MAINTAINER email address for the following ports were inadvertently submitted [1] as FreeBSD.org addresses: - ports r489429 (lang/cmucl) via bug 232011 - ports r489430 (lang/cmucl-extra) via bug 233195 This change updates MAINTAINER lines to the correct address. PR: 234655 [1], 232011, 233195 Submitted by: Lorenzo Salvadore <phascolarctos protonmail ch> (maintainer) Changes: head/lang/cmucl/Makefile head/lang/cmucl-extra/Makefile