Created attachment 199224 [details] Update byobu to 5.127. I'd like to maintain this port, if approved. Files REMOVED: files/patch-usr_lib_byobu_battery files/patch-usr_lib_byobu_cpu__count files/patch-usr_lib_byobu_cpu__freq files/patch-usr_lib_byobu_cpu__temp files/patch-usr_lib_byobu_ec2__cost files/patch-usr_lib_byobu_entropy files/patch-usr_lib_byobu_fan__speed files/patch-usr_lib_byobu_ip__address files/patch-usr_lib_byobu_load__average files/patch-usr_lib_byobu_memory files/patch-usr_lib_byobu_network files/patch-usr_lib_byobu_processes files/patch-usr_lib_byobu_raid files/patch-usr_lib_byobu_rcs__cost files/patch-usr_lib_byobu_reboot__required files/patch-usr_lib_byobu_swap files/patch-usr_lib_byobu_uptime These individual patches were replaced with a find/replace in the Makefile. Only one (files/patch-usr_lib_byobu_disk) needs to remain.
Created attachment 199225 [details] Update byobu to 5.127 Fixed whitespace that was causing patch to fail.
Thank you for offering to maintain a port Justin
Created attachment 199239 [details] Update byobu to 5.127 Apologies for another revision, there was a stealthy change to some shebangs upstream that caused breakage on reconnect that I missed in initial testing.
Take
Created attachment 199298 [details] byobu_5.127_v2.patch New version that removes two unneeded patches and makes some cosmetic changes
Hi Justin, Thanks for the submission! I attached a new version for the patch. There were two patches in files/ that can't be applied since the files to be patched are removed from the new version. I tested it on 11.2 amd64 and it seems to run fine, but could you please apply an extra couple of eyes and see if it looks good to you? Thanks!
From the original submission, all but one of the patch files in files/ were supposed to be removed. Files REMOVED: files/patch-usr_lib_byobu_battery files/patch-usr_lib_byobu_cpu__count files/patch-usr_lib_byobu_cpu__freq files/patch-usr_lib_byobu_cpu__temp files/patch-usr_lib_byobu_ec2__cost files/patch-usr_lib_byobu_entropy files/patch-usr_lib_byobu_fan__speed files/patch-usr_lib_byobu_ip__address files/patch-usr_lib_byobu_load__average files/patch-usr_lib_byobu_memory files/patch-usr_lib_byobu_network files/patch-usr_lib_byobu_processes files/patch-usr_lib_byobu_raid files/patch-usr_lib_byobu_rcs__cost files/patch-usr_lib_byobu_reboot__required files/patch-usr_lib_byobu_swap files/patch-usr_lib_byobu_uptime From the ports maintenance handbook, it says to list which files were removed in the PR. Did I do this wrong?
Created attachment 199299 [details] v3 of patch with removed patches
(In reply to Justin Coffman from comment #7) I thought the list of removed files was informational only :-) You can always remove the files and then run svn diff so when applied (with patch -E < patchfile) the files are automatically removed. That way all the changes are included in the .patch file. The v3 patch file should do that. Also notice that I removed PORTREVISION since we are bumping PORTVERSION.
Thank you for the guidance!
(In reply to Justin Coffman from comment #10) You're welcome! Have a look at the port and if it looks good, I will proceed during the weekend.
(In reply to Fernando ApesteguÃa from comment #11) Everything looks good. Thanks for the help.
A commit references this bug: Author: fernape Date: Sun Nov 18 21:26:14 UTC 2018 New revision: 485277 URL: https://svnweb.freebsd.org/changeset/ports/485277 Log: sysutils/byobu: Update to 5.127 Also give maintainership to jcoffman@openfire.io PR: 233216 Submitted by: jcoffman@openfire.io Changes: head/sysutils/byobu/Makefile head/sysutils/byobu/distinfo head/sysutils/byobu/files/patch-usr_lib_byobu_battery head/sysutils/byobu/files/patch-usr_lib_byobu_cpu__count head/sysutils/byobu/files/patch-usr_lib_byobu_cpu__freq head/sysutils/byobu/files/patch-usr_lib_byobu_cpu__temp head/sysutils/byobu/files/patch-usr_lib_byobu_ec2__cost head/sysutils/byobu/files/patch-usr_lib_byobu_entropy head/sysutils/byobu/files/patch-usr_lib_byobu_fan__speed head/sysutils/byobu/files/patch-usr_lib_byobu_ip__address head/sysutils/byobu/files/patch-usr_lib_byobu_load__average head/sysutils/byobu/files/patch-usr_lib_byobu_memory head/sysutils/byobu/files/patch-usr_lib_byobu_network head/sysutils/byobu/files/patch-usr_lib_byobu_processes head/sysutils/byobu/files/patch-usr_lib_byobu_raid head/sysutils/byobu/files/patch-usr_lib_byobu_rcs__cost head/sysutils/byobu/files/patch-usr_lib_byobu_reboot__required head/sysutils/byobu/files/patch-usr_lib_byobu_swap head/sysutils/byobu/files/patch-usr_lib_byobu_uptime head/sysutils/byobu/pkg-plist
Committed, Thanks!