Bug 233364 - graphics/GraphicsMagick: fixes and improves options management
Summary: graphics/GraphicsMagick: fixes and improves options management
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-21 00:45 UTC by Lorenzo Salvadore
Modified: 2018-11-24 22:35 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)


Attachments
GraphicsMagick patch (2.87 KB, patch)
2018-11-21 00:45 UTC, Lorenzo Salvadore
salvadore: maintainer-approval? (sunpoet)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lorenzo Salvadore freebsd_committer freebsd_triage 2018-11-21 00:45:27 UTC
Created attachment 199394 [details]
GraphicsMagick patch

My patch extends the number of available options consistently with what is listed by the configure script (./configure --help) in the distfile. The extension is also necessary to prevent undeclared dependencies to be established with ports that might be already installed in the system.

- Reorders variables consitently with the official order: moves USE_LD line in the USE variables block, puts all OPTIONS variables in the same block (the last block).
- Adds options BZIP2, LZMA, TRIO, UMEM, ZLIB, ZSTD.
- Makes BZIP2, LZMA and ZLIB default, as the necessary libraries for them are in base system.
- Corrects LCMS2_CONFIGURE= in LCMS2_CONFIGURE_WITH=.
- Bumps PORTREVISION, because for at least one of the new options (ZSTD) if the necessary library was present by chance on the system (i.e. if archivers/zstd was installed), then GraphicsMagick would link to libzstd.so without having archivers/zstd as a dependency (and uninstalling archivers/zstd would then break GraphicsMagick without any warning).

The patch has been successfully tested with portlint and poudriere (11.2-RELEASE amd64/i386).
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-11-24 22:33:07 UTC
A commit references this bug:

Author: sunpoet
Date: Sat Nov 24 22:32:25 UTC 2018
New revision: 485830
URL: https://svnweb.freebsd.org/changeset/ports/485830

Log:
  Add more options

  - Fix LCMS2 option
  - Bump PORTREVISION for package change

  PR:		233364
  Submitted by:	Lorenzo Salvadore <phascolarctos@protonmail.ch>

Changes:
  head/graphics/GraphicsMagick/Makefile
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2018-11-24 22:35:35 UTC
Committed. Thanks!