Bug 233422 - devel/devtodo: Remove defunct post-patch
Summary: devel/devtodo: Remove defunct post-patch
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords: easy
Depends on:
Blocks: 229925
  Show dependency tree / graph
 
Reported: 2018-11-23 03:17 UTC by Kyle Evans
Modified: 2019-02-26 08:35 UTC (History)
0 users

See Also:
koobs: merge-quarterly?

Attachments
svn(1) diff against devel/devtodo (423 bytes, patch)
2018-11-23 03:17 UTC, Kyle Evans 		koobs: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle Evans freebsd_committer freebsd_triage 2018-11-23 03:17:28 UTC 
Created attachment 199466 [details]
svn(1) diff against devel/devtodo

This REINPLACE_CMD is not operational, and likely hasn't ever been -- sed in base does not process \t as a tab but as an escaped ordinary 't' character. This will be forbidden in future versions of regex(3).

Remove the post-patch; it's not operational, so it's not clear what purpose it is serving anymore. This can be verified by checking diff Makefile.in.bak Makefile.in on the file that's being patched -- no changes are to be made.

Thanks,

Kyle Evans
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2018-11-23 03:26:37 UTC 
Reporter is (src) committer, assign accordingly.

Change is:

- A blanket approval candidate (either under just-fix-it, or non-functional ports-compliance)
- If not above, implicitly Approved by: portmgr (unmaintained port)
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2018-11-23 03:27:26 UTC 
Comment on attachment 199466 [details]
svn(1) diff against devel/devtodo

Approved by: koobs (ports)
Approved by: portmgr (unmaintained port)
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-02-26 08:35:13 UTC 
A commit references this bug:

Author: tobik
Date: Tue Feb 26 08:34:43 UTC 2019
New revision: 493947
URL: https://svnweb.freebsd.org/changeset/ports/493947

Log:
  devel/devtodo: Remove defunct post-patch

  post-patch is not operational, and likely hasn't ever been -- sed
  in base does not process \t as a tab but as an escaped ordinary 't'
  character.  This will be forbidden in future versions of regex(3).

  PR:		233422
  Submitted by:	kevans

Changes:
  head/devel/devtodo/Makefile