Bug 233456 - math/secp256k1: include module "recovery"
Summary: math/secp256k1: include module "recovery"
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alex Dupre
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-23 23:19 UTC by robert.ayrapetyan
Modified: 2018-11-26 08:27 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (ale)

Attachments
Makefile diff for adding recovery module support (380 bytes, patch)
2018-11-23 23:19 UTC, robert.ayrapetyan 		no flags Details | Diff
upd version (575 bytes, patch)
2018-11-23 23:19 UTC, robert.ayrapetyan 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description robert.ayrapetyan 2018-11-23 23:19:01 UTC 
Created attachment 199500 [details]
Makefile diff for adding recovery module support

When compiled without "--enable-module-recovery",

import coincurve

in python raises:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/ara/devel/blockchain/venv/lib/python3.6/site-packages/coincurve/__init__.py", line 1, in <module>
    from coincurve.context import GLOBAL_CONTEXT, Context
  File "/ara/devel/blockchain/venv/lib/python3.6/site-packages/coincurve/context.py", line 4, in <module>
    from coincurve.flags import CONTEXT_ALL, CONTEXT_FLAGS
  File "/ara/devel/blockchain/venv/lib/python3.6/site-packages/coincurve/flags.py", line 1, in <module>
    from ._libsecp256k1 import lib
ImportError: /ara/devel/blockchain/venv/lib/python3.6/site-packages/coincurve/_libsecp256k1.so: Undefined symbol "secp256k1_ecdsa_recoverable_signature_convert"

Attached is a patch for a Makefile.
Thanks.
Comment 1 robert.ayrapetyan 2018-11-23 23:19:35 UTC 
Created attachment 199501 [details]
upd version
Comment 2 commit-hook freebsd_committer freebsd_triage 2018-11-26 08:20:31 UTC 
A commit references this bug:

Author: ale
Date: Mon Nov 26 08:20:12 UTC 2018
New revision: 485928
URL: https://svnweb.freebsd.org/changeset/ports/485928

Log:
  Update to latest snapshot and include module "recovery".

  PR:		233456
  Submitted by:	robert.ayrapetyan@gmail.com

Changes:
  head/math/secp256k1/Makefile
  head/math/secp256k1/distinfo
  head/math/secp256k1/pkg-plist