Bug 233458 - net-mgmt/nagiosql: remove redundant regex escapes
Summary: net-mgmt/nagiosql: remove redundant regex escapes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks: 229925
  Show dependency tree / graph
 
Reported: 2018-11-24 02:01 UTC by Kyle Evans
Modified: 2019-02-26 08:58 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (chris)

Attachments
svn(1) diff against net-mgmt/nagiosql (991 bytes, patch)
2018-11-24 02:01 UTC, Kyle Evans 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle Evans freebsd_committer freebsd_triage 2018-11-24 02:01:29 UTC 
Created attachment 199503 [details]
svn(1) diff against net-mgmt/nagiosql

Hi,

nagiosql's Makefile currently has some redundant escaping of single quotes in its Makefile. These get passed through as escaped single quotes to regex(3), which is an escape of an ordinary character. Such escapes will be forbidden in a future version of regex(3), so we'll get ahead of the game and remove said escapes now.

While here, there are two questionable expressions: -e "s|\>/etc/nagiosql|\>${ETCDIR}|g" and the one immediately following it. \> is a word delimiter (see reformat(7)), and will only match as such. If this were to match, it would replace <word delimiter>/etc/nagiosql with >${ETCDIR} -- this likely works as intended now, but I think it was intended that it matches a literal >/etc/nagiosql, so the included patch treats it accordingly.

Thanks,

Kyle Evans
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-02-26 08:56:36 UTC 
A commit references this bug:

Author: tobik
Date: Tue Feb 26 08:56:31 UTC 2019
New revision: 493951
URL: https://svnweb.freebsd.org/changeset/ports/493951

Log:
  net-mgmt/nagiosql: Remove redundant regex escapes

  nagiosql's Makefile currently has some redundant escaping of single
  quotes in its Makefile.  These get passed through as escaped single
  quotes to regex(3), which is an escape of an ordinary character.
  Such escapes will be forbidden in a future version of regex(3), so
  we'll get ahead of the game and remove said escapes now.

  While here, there are two questionable expressions: -e
  "s|\>/etc/nagiosql|\>${ETCDIR}|g" and the one immediately following
  it.  \> is a word delimiter (see reformat(7)), and will only match
  as such.  If this were to match, it would replace <word
  delimiter>/etc/nagiosql with >${ETCDIR} -- this likely works as
  intended now, but I think it was intended that it matches a literal
  >/etc/nagiosql, so the included patch treats it accordingly.

  - While here reset MAINTAINER after a timeout of 3 months and
    repeated previous timeouts

  PR:		233458
  Submitted by:	kevans
  Approved by:	chris@smartt.com (maintainer timeout, 3 months)

Changes:
  head/net-mgmt/nagiosql/Makefile
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-02-26 08:57:39 UTC 
A commit references this bug:

Author: tobik
Date: Tue Feb 26 08:57:31 UTC 2019
New revision: 493952
URL: https://svnweb.freebsd.org/changeset/ports/493952

Log:
  net-mgmt/nagiosql: Actually reset MAINTAINER after r493951

  PR:		233458

Changes:
  head/net-mgmt/nagiosql/Makefile
Comment 3 Tobias Kortkamp freebsd_committer freebsd_triage 2019-02-26 08:58:02 UTC 
This change seems to not be good.
Comment 4 Tobias Kortkamp freebsd_committer freebsd_triage 2019-02-26 08:58:36 UTC 
(In reply to Tobias Kortkamp from comment #3)
> This change seems to not be good.

Sorry I forgot to delete this... Actually it was just fine.