Bug 233459 - math/octave: point the configure script at gsed for regex correctness
Summary: math/octave: point the configure script at gsed for regex correctness
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Stephen Montgomery-Smith
URL:
Keywords:
Depends on:
Blocks: 229925
  Show dependency tree / graph
 
Reported: 2018-11-24 02:13 UTC by Kyle Evans
Modified: 2018-11-24 21:57 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (stephen)

Attachments
svn(1) diff against math/octave (492 bytes, patch)
2018-11-24 02:13 UTC, Kyle Evans 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle Evans freebsd_committer freebsd_triage 2018-11-24 02:13:26 UTC 
Created attachment 199504 [details]
svn(1) diff against math/octave

Hi,

octave's build process features this bit near the middle/end: sed -ne '/^\x1d/,$p' ./libinterp/op-kw-docs

This is expecting \x1d to be properly inserted in the pattern, which does not currently happen with our sed. Swap it out for gsed for the time being until our sed becomes capable -- the BUILD_DEPENDS on gsed was already there, it was mainly a matter of forcing it into the configure script.

Thanks,

Kyle Evans
Comment 1 Stephen Montgomery-Smith freebsd_committer freebsd_triage 2018-11-24 20:12:54 UTC 
This is going to take a lot of investigation.  I have no idea why the configure script ends up using /usr/bin/sed, when it seems clear to me that it should search for gsed.

I tried a number of things:
SED = ${LOCALBASE}/bin/gsed in CONFIGURE_ARG
replacing all occurences of sed with gsed in configure

but none of these worked.

Do you have any ideas?
Comment 2 Kyle Evans freebsd_committer freebsd_triage 2018-11-24 20:15:41 UTC 
(In reply to Stephen Montgomery-Smith from comment #1)

Hi,

My experience is that autoconf is super annoying about it. =( The attached patch is generally what I've had to do, though- force ac_cv_path_SED (rather than just SED) in CONFIGURE_ENV.
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-11-24 21:55:36 UTC 
A commit references this bug:

Author: stephen
Date: Sat Nov 24 21:55:20 UTC 2018
New revision: 485798
URL: https://svnweb.freebsd.org/changeset/ports/485798

Log:
  - Have the build process use gsed instead of sed.

  PR:		ports/233459
  Submitted by:	Kyle Evans <kevans@freebsd.org>

Changes:
  head/math/octave/Makefile
Comment 4 Stephen Montgomery-Smith freebsd_committer freebsd_triage 2018-11-24 21:57:47 UTC 
Committed, thanks.