Bug 233485 - devel/git: build fails if DEVELOPER env var is set (again; tweak the previous fix)
Summary: devel/git: build fails if DEVELOPER env var is set (again; tweak the previous...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Renato Botelho
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-24 23:42 UTC by John Hein
Modified: 2018-12-10 18:52 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (garga)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2018-11-24 23:42:57 UTC 
See bug 214009 for history.

Since git-2.18.*, the DEVELOPER_CFLAGS= trick doesn't work when DEVELOPER=yes is set.

Updated fix:

Index: Makefile
===================================================================
--- Makefile    (revision 485765)
+++ Makefile    (working copy)
@@ -28,7 +28,7 @@
 USES=          autoreconf gmake iconv shebangfix ssl tar:xz
 CPPFLAGS+=     -isystem${LOCALBASE}/include
 LDFLAGS+=      -L${LOCALBASE}/lib
-MAKE_ARGS+=    DEVELOPER_CFLAGS=
+MAKE_ARGS+=    DEVELOPER=
 MAKE_ENV+=     V=1
 USE_RC_SUBR=   git_daemon
 SHEBANG_FILES= *.perl */*.perl */*/*.perl */*.pl */*/*.pl */*/*/*.pl \
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-12-10 18:52:03 UTC 
A commit references this bug:

Author: garga
Date: Mon Dec 10 18:51:10 UTC 2018
New revision: 487197
URL: https://svnweb.freebsd.org/changeset/ports/487197

Log:
  devel/git:

  - Update to 2.20.0
  - Fix build when DEVELOPER env var is set [1]

  PR:		233485 [1]
  Submitted by:	John Hein <z7dr6ut7gs@snkmail.com> [1]
  Sponsored by:	Rubicon Communications, LLC (Netgate)

Changes:
  head/devel/git/Makefile
  head/devel/git/distinfo
  head/devel/git/pkg-plist