Bug 234030 - misc/iso-codes: USES=gettext-tools instead of gettext
Summary: misc/iso-codes: USES=gettext-tools instead of gettext
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Koop Mast
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2018-12-15 01:45 UTC by John Hein
Modified: 2018-12-17 19:13 UTC (History)
1 user (show)

See Also:
kwm: maintainer-feedback+
kwm: merge-quarterly-


Attachments
[patch] USES=gettext-tools instead of gettext (336 bytes, patch)
2018-12-15 01:45 UTC, John Hein
jcfyecrayz: maintainer-approval? (kwm)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2018-12-15 01:45:00 UTC
Created attachment 200125 [details]
[patch] USES=gettext-tools instead of gettext

misc/iso-codes has a build dependency on devel/gettext-tools, but USES has gettext.

Patch included that changes to USES=gettext-tools (default is :build).

No need to bump the PORTREVISION for this, IMO.  It doesn't change the package's file contents although it will modify the dependency list, so  a more strict take would be that this alters the package and a PORTREVISION is needed.  I'll leave it up to the committer (but I'm curious to know if the project has guidelines written down for this case - the PORTREVISION section in the PHB doesn't address this nuance specifically).

While here, pet portlint and move some entries out of the USES section.

QA:
 poudriere testport - ok
 portlint - ok, no new warnings
Comment 1 commit-hook freebsd_committer freebsd_triage 2018-12-16 21:42:06 UTC
A commit references this bug:

Author: kwm
Date: Sun Dec 16 21:41:27 UTC 2018
New revision: 487633
URL: https://svnweb.freebsd.org/changeset/ports/487633

Log:
  Switch to gettext-tools, we only need for building.
  While here, pet portlint and move some entries out of the USES section.

  PR:		234030
  Submitted by:	John Hein <z7dr6ut7gs@snkmail.com>

Changes:
  head/misc/iso-codes/Makefile
Comment 2 Koop Mast freebsd_committer freebsd_triage 2018-12-16 21:46:37 UTC
I don't think this is MFC is really needed. In about 15 days there will be a new branch and this isn't a real critical bug.
Comment 3 John Hein 2018-12-17 19:13:57 UTC
(In reply to Koop Mast from comment #2)
Agreed on non-urgency, so no-MFC.  Thanks, Koop.

John