Bug 234059 - misc/kdeutils: Add OPTIONS
Summary: misc/kdeutils: Add OPTIONS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-kde (group)
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2018-12-16 12:41 UTC by Ivan
Modified: 2018-12-19 15:12 UTC (History)
2 users (show)

See Also:
tcberner: maintainer-feedback+


Attachments
kdeutils patch (2.63 KB, patch)
2018-12-16 12:41 UTC, Ivan
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan 2018-12-16 12:41:56 UTC
Created attachment 200151 [details]
kdeutils patch

Usually all utilities are not needed and kgpg pulls PIM stuff I don't use. Let's add some options to this metaport :P
Comment 1 Tobias C. Berner freebsd_committer freebsd_triage 2018-12-16 14:02:17 UTC
Moin moin


If you don't want the meta-port, don't install the metaport... So, I'm not sure if adding options to a pure dependency port is sensible, but I will think on it :)


mfg Tobias
Comment 2 Ivan 2018-12-16 14:11:34 UTC
Hello,
I thought this is why metaports exits - to collect similar stuff and allow user to choose what he or she wants. Some other KDE metaports have such options. 
BTW, base apps could have options too, for example, konqueror is half broken and who cares about helpcenter.
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-12-19 14:54:34 UTC
A commit references this bug:

Author: adridg
Date: Wed Dec 19 14:53:54 UTC 2018
New revision: 487800
URL: https://svnweb.freebsd.org/changeset/ports/487800

Log:
  Add OPTIONS to misc/kdeutils.

  Like, say, graphics/kdegraphics, this is a metaport where all the dependency
  ports may be considered optional. Add options to allow selecting all the
  bits. By default, select all of them. Bump PORTREVISION because the PHB
  says that changes applying to non-default options also count -- although
  that seems a bit sketchy here.

  PR:		234059
  Submitted by:	bsd@abinet.ru
  Reported by:	bsd@abinet.ru

Changes:
  head/misc/kdeutils/Makefile
Comment 4 Adriaan de Groot freebsd_committer freebsd_triage 2018-12-19 15:12:56 UTC
Applied, thanks! (with some changes to the port descriptions -- "for KDE" is something we no longer try to add all over the place, since the applications work fine everywhere)