Bug 234064 - security/krb5: fix build with LibreSSL 2.9
Summary: security/krb5: fix build with LibreSSL 2.9
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Cy Schubert
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-16 16:59 UTC by Charlie Li
Modified: 2019-04-30 19:38 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (cy)


Attachments
WIP patch (2.98 KB, patch)
2018-12-16 16:59 UTC, Charlie Li
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Charlie Li freebsd_committer freebsd_triage 2018-12-16 16:59:23 UTC
Created attachment 200157 [details]
WIP patch

LibreSSL 2.9 further improved compatibility with OpenSSL 1.1 with regards to using <openssl/asn1t.h> and deprecating <openssl/asn1_mac.h>, with LibreSSL removing the latter file entirely over OpenSSL's friendly deprecation error. This fixes the logic for LibreSSL 2.9.

However, there is now a separate build error:

cc -fpic -DSHARED -DHAVE_CONFIG_H  -I../../../include -I../../../include  -DKRB5_DEPRECATED=1 -DKRB5_PRIVATE -I/usr/local/include -I/usr/local/include -isystem /usr/local/include -O2 -pipe -march=broadwell  -fstack-protector -isystem /usr/local/include -fno-strict-aliasing -std=gnu99  -Werror=unknown-warning-option -Wall -Wcast-align -Wshadow -Wmissing-prototypes -pedantic -Wno-format-zero-length -Woverflow -Wstrict-overflow -Wmissing-format-attribute -Wmissing-prototypes -Wreturn-type -Wmissing-braces -Wparentheses -Wswitch -Wunused-function -Wunused-label -Wunused-variable -Wunused-value -Wunknown-pragmas -Wsign-compare -Wnewline-eof -Werror=uninitialized -Werror=pointer-arith -Werror=int-conversion -Werror=incompatible-pointer-types -Werror=implicit-int -Werror=declaration-after-statement -Werror-implicit-function-declaration -pthread  -c pkinit_crypto_openssl.c -o pkinit_crypto_openssl.so.o && mv -f pkinit_crypto_openssl.so.o pkinit_crypto_openssl.so
rm -f ../pkinit.so
(cd .. && ln -s `basename plugins/preauth/pkinit`/pkinit.so .)
pkinit_crypto_openssl.c:3072:2: error: expected ';' after top level declarator
} static_ASN1_SEQUENCE_END_name(int_dhvparams, DHvparams)
 ^
 ;
1 error generated.
gmake[2]: *** [Makefile:826: pkinit_crypto_openssl.so] Error 1
gmake[2]: Leaving directory '/wrkdirs/usr/ports/security/krb5/work/krb5-1.16.2/src/plugins/preauth/pkinit'
gmake[1]: *** [Makefile:1527: all-recurse] Error 1
gmake[1]: Leaving directory '/wrkdirs/usr/ports/security/krb5/work/krb5-1.16.2/src'
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-03-12 04:19:15 UTC
A commit references this bug:

Author: cy
Date: Tue Mar 12 04:18:34 UTC 2019
New revision: 495423
URL: https://svnweb.freebsd.org/changeset/ports/495423

Log:
  Fix build with LibreSSL 2.9.

  PR:		234064
  Submitted by:	Charlie Li <ml+freebsd@vishwin.info>

Changes:
  head/security/krb5-115/files/patch-plugins_preauth_pkinit_pkinit__crypto__openssl.c
  head/security/krb5-115/files/patch-plugins_preauth_pkinit_pkinit__crypto__openssl.h
  head/security/krb5-116/files/patch-plugins_preauth_pkinit_pkinit__crypto__openssl.c
  head/security/krb5-116/files/patch-plugins_preauth_pkinit_pkinit__crypto__openssl.h
  head/security/krb5-117/files/patch-plugins_preauth_pkinit_pkinit__crypto__openssl.c
  head/security/krb5-117/files/patch-plugins_preauth_pkinit_pkinit__crypto__openssl.h
  head/security/krb5-devel/files/patch-plugins_preauth_pkinit_pkinit__crypto__openssl.c
  head/security/krb5-devel/files/patch-plugins_preauth_pkinit_pkinit__crypto__openssl.h
Comment 2 Cy Schubert freebsd_committer freebsd_triage 2019-03-12 04:20:04 UTC
Committed. Thanks for the patch.
Comment 3 Peter Putzer 2019-04-28 06:16:33 UTC
(In reply to Cy Schubert from comment #2)

Can you please do a new release of the port? Now that security/libressl has been bumped  to 2.9, this has become somewhat urgent.