Bug 234189 - net/freerdp: Update to 2.0.0-rc4
Summary: net/freerdp: Update to 2.0.0-rc4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kyle Evans
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-20 01:03 UTC by Koichiro Iwao
Modified: 2018-12-20 07:49 UTC (History)
1 user (show)

See Also:
meta: maintainer-feedback+

Attachments
patch (1.45 KB, text/plain)
2018-12-20 01:03 UTC, Koichiro Iwao 		kevans: maintainer-approval+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Koichiro Iwao freebsd_committer freebsd_triage 2018-12-20 01:03:13 UTC 
Created attachment 200292 [details]
patch

testbuild@120amd64 passed for me. xfreerdp properly works for me.
Comment 1 Kyle Evans freebsd_committer freebsd_triage 2018-12-20 03:50:13 UTC 
Comment on attachment 200292 [details]
patch

(In reply to Koichiro Iwao from comment #0)

Hi,

I was holding off on this until the 2.0.0 release, which I thought was close, but this seems appropriate now given that the goalpost appears to be moving. PORTREVISION can be omitted entirely, though, no?
Comment 2 Koichiro Iwao freebsd_committer freebsd_triage 2018-12-20 04:35:23 UTC 
(In reply to Kyle Evans from comment #1)

Yes, their RC is a little bit different from common RC as we know as release candidate. They makes lots of significant changes between RC releases. See `git shortlog  2.0.0-rc3..2.0.0-rc4` in upstream repository.

PORTREVISION=0 can be omitted.
Comment 3 Kyle Evans freebsd_committer freebsd_triage 2018-12-20 04:40:23 UTC 
(In reply to Koichiro Iwao from comment #2)

Right- a guy can dream of a final release, though. =) I really want a final release so guacamole will adapt and I can drop freerdp1, but meh. =(

Feel free commit at will with or without PORTREVISION omitted; I trust your Q/A.
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-12-20 05:05:20 UTC 
A commit references this bug:

Author: meta
Date: Thu Dec 20 05:04:34 UTC 2018
New revision: 487838
URL: https://svnweb.freebsd.org/changeset/ports/487838

Log:
  net/freerdp: Update to 2.0.0-rc4

  PR:		234189
  Submitted by:	myself
  Approved by:	kevans (maintainer), mentors (implicit)

Changes:
  head/net/freerdp/Makefile
  head/net/freerdp/distinfo
  head/net/freerdp/pkg-plist
Comment 5 Koichiro Iwao freebsd_committer freebsd_triage 2018-12-20 05:06:34 UTC 
Commited, thanks!
Comment 6 aryeh.friedman 2018-12-20 06:59:47 UTC 
Fails to build with libressl-2.8.3:

Environment:

FreeBSD lilith 11.2-RELEASE-p4 FreeBSD 11.2-RELEASE-p4 #0 r339065: Mon Oct  1 14:01:40 EDT 2018     root@lilith:/usr/obj/usr/src/sys/GENERIC  amd64

Error snippet:

[1/2] : && /usr/bin/cc -O2 -pipe  -fstack-protector -isystem /usr/local/include -fno-strict-aliasing -Wno-unused-parameter -Wno-unused-macros -Wno-padded -Wno-c11-extensions -Wno-gnu -Wno-unused-command-line-argument -Wno-deprecated-declarations -DWINPR_DLL -O2 -pipe  -fstack-protector -isystem /usr/local/include -fno-strict-aliasing  -Wl,-rpath,/usr/local/lib -fstack-protector client/X11/CMakeFiles/xfreerdp-client.dir/xf_gdi.c.o client/X11/CMakeFiles/xfreerdp-client.dir/xf_gfx.c.o client/X11/CMakeFiles/xfreerdp-client.dir/xf_rail.c.o client/X11/CMakeFiles/xfreerdp-client.dir/xf_tsmf.c.o client/X11/CMakeFiles/xfreerdp-client.dir/xf_input.c.o client/X11/CMakeFiles/xfreerdp-client.dir/xf_event.c.o client/X11/CMakeFiles/xfreerdp-client.dir/xf_floatbar.c.o client/X11/CMakeFiles/xfreerdp-client.dir/xf_channels.c.o client/X11/CMakeFiles/xfreerdp-client.dir/xf_cliprdr.c.o client/X11/CMakeFiles/xfreerdp-client.dir/xf_monitor.c.o client/X11/CMakeFiles/xfreerdp-client.dir/xf_disp.c.o client/X11/CMakeFiles/xfreerdp-client.dir/xf_graphics.c.o client/X11/CMakeFiles/xfreerdp-client.dir/xf_keyboard.c.o client/X11/CMakeFiles/xfreerdp-client.dir/xf_video.c.o client/X11/CMakeFiles/xfreerdp-client.dir/xf_window.c.o client/X11/CMakeFiles/xfreerdp-client.dir/xf_client.c.o client/X11/CMakeFiles/xfreerdp-client.dir/cli/xfreerdp.c.o  -o client/X11/xfreerdp -L/usr/local/lib -Wl,-rpath,/usr/ports/net/freerdp/work/.build/client/common:/usr/ports/net/freerdp/work/.build/libfreerdp:/usr/ports/net/freerdp/work/.build/winpr/libwinpr:/usr/local/lib: /usr/local/lib/libX11.so /usr/local/lib/libXinerama.so /usr/local/lib/libXext.so /usr/local/lib/libXcursor.so /usr/local/lib/libXv.so /usr/local/lib/libXi.so /usr/local/lib/libXrender.so /usr/local/lib/libXrandr.so /usr/local/lib/libXfixes.so client/common/libfreerdp-client2.so.2.0.0 libfreerdp/libfreerdp2.so.2.0.0 -lm -lrt winpr/libwinpr/libwinpr2.so.2.0.0 && :
FAILED: client/X11/xfreerdp 
: && /usr/bin/cc -O2 -pipe  -fstack-protector -isystem /usr/local/include -fno-strict-aliasing -Wno-unused-parameter -Wno-unused-macros -Wno-padded -Wno-c11-extensions -Wno-gnu -Wno-unused-command-line-argument -Wno-deprecated-declarations -DWINPR_DLL -O2 -pipe  -fstack-protector -isystem /usr/local/include -fno-strict-aliasing  -Wl,-rpath,/usr/local/lib -fstack-protector client/X11/CMakeFiles/xfreerdp-client.dir/xf_gdi.c.o client/X11/CMakeFiles/xfreerdp-client.dir/xf_gfx.c.o client/X11/CMakeFiles/xfreerdp-client.dir/xf_rail.c.o client/X11/CMakeFiles/xfreerdp-client.dir/xf_tsmf.c.o client/X11/CMakeFiles/xfreerdp-client.dir/xf_input.c.o client/X11/CMakeFiles/xfreerdp-client.dir/xf_event.c.o client/X11/CMakeFiles/xfreerdp-client.dir/xf_floatbar.c.o client/X11/CMakeFiles/xfreerdp-client.dir/xf_channels.c.o client/X11/CMakeFiles/xfreerdp-client.dir/xf_cliprdr.c.o client/X11/CMakeFiles/xfreerdp-client.dir/xf_monitor.c.o client/X11/CMakeFiles/xfreerdp-client.dir/xf_disp.c.o client/X11/CMakeFiles/xfreerdp-client.dir/xf_graphics.c.o client/X11/CMakeFiles/xfreerdp-client.dir/xf_keyboard.c.o client/X11/CMakeFiles/xfreerdp-client.dir/xf_video.c.o client/X11/CMakeFiles/xfreerdp-client.dir/xf_window.c.o client/X11/CMakeFiles/xfreerdp-client.dir/xf_client.c.o client/X11/CMakeFiles/xfreerdp-client.dir/cli/xfreerdp.c.o  -o client/X11/xfreerdp -L/usr/local/lib -Wl,-rpath,/usr/ports/net/freerdp/work/.build/client/common:/usr/ports/net/freerdp/work/.build/libfreerdp:/usr/ports/net/freerdp/work/.build/winpr/libwinpr:/usr/local/lib: /usr/local/lib/libX11.so /usr/local/lib/libXinerama.so /usr/local/lib/libXext.so /usr/local/lib/libXcursor.so /usr/local/lib/libXv.so /usr/local/lib/libXi.so /usr/local/lib/libXrender.so /usr/local/lib/libXrandr.so /usr/local/lib/libXfixes.so client/common/libfreerdp-client2.so.2.0.0 libfreerdp/libfreerdp2.so.2.0.0 -lm -lrt winpr/libwinpr/libwinpr2.so.2.0.0 && :
libfreerdp/libfreerdp2.so.2.0.0: undefined reference to `SSL_CTX_set_security_level'
cc: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.
Comment 7 Koichiro Iwao freebsd_committer freebsd_triage 2018-12-20 07:49:47 UTC 
This upstream patch needs to be backported:
https://github.com/FreeRDP/FreeRDP/commit/effa8b8562d5e4b017570815c7e4d8faa0dd9a9e

I'll create anoter bug.