Bug 234257 - lang/gauche: update 0.9.6 -> 0.9.7
Summary: lang/gauche: update 0.9.6 -> 0.9.7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexey Dokuchaev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-21 18:53 UTC by Kurt Jaeger
Modified: 2018-12-29 08:09 UTC (History)
1 user (show)

See Also:


Attachments
patch (55.96 KB, patch)
2018-12-21 18:53 UTC, Kurt Jaeger
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kurt Jaeger freebsd_committer freebsd_triage 2018-12-21 18:53:11 UTC
Created attachment 200346 [details]
patch

Testbuilds look fine.

make test fails. Is this update still useful or how can the tests be fixed ?

Testing utility scripts ...                                      failed.
discrepancies found.  Errors are:
test cf-check-lib set LIBS: expects ("LIBS = -lm") => got ("LIBS = -lcrypt -lutil -lrt -lm  -pthread")

Total: 19691 tests, 19689 passed,     2 failed,     0 aborted.
Comment 1 Kurt Jaeger freebsd_committer freebsd_triage 2018-12-21 19:13:32 UTC
Changelog: http://practical-scheme.net/gauche/gmemo/?Release%200.9.7
Comment 2 Kurt Jaeger freebsd_committer freebsd_triage 2018-12-22 20:26:33 UTC
make test in the old version 0.9.6 does not fail on two tests.
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-12-29 08:03:33 UTC
A commit references this bug:

Author: danfe
Date: Sat Dec 29 08:03:25 UTC 2018
New revision: 488658
URL: https://svnweb.freebsd.org/changeset/ports/488658

Log:
  - Update `lang/gauche' to version 0.9.7
  - Fix two tests that are failing on FreeBSD: one because clang aborts due
    to failed assertion when trying to compile ``extern void sin(); sin();'':

      Assertion failed: (Arg < NumArgs && "Arg access out of range!"),
      function getArg, file
      /usr/src/contrib/llvm/tools/clang/include/clang/AST/Expr.h, line 2283.
      cc: error: unable to execute command: Abort trap (core dumped)

    Another test (cf-check-lib) fails because of the LIBS variable which is
    passed on the TEST_ENV list.  Since there's nothing useful to the tests
    there anyway, just ensure it is empty

  PR:	234257

Changes:
  head/lang/gauche/Makefile
  head/lang/gauche/distinfo
  head/lang/gauche/files/patch-src_Makefile.in
  head/lang/gauche/pkg-plist
Comment 4 Alexey Dokuchaev freebsd_committer freebsd_triage 2018-12-29 08:09:57 UTC
These two tests were added recently, and are a bit fragile ATM (aggressive "(cf-check-lib "m" "sin")" test which causes clang to segfault, and other is subject to LIB variable pollution from the environment) and should be fixed.
I'd report this upstream (probably already next year. :-)

I've committed version update, but left other, unrelated and non-functional changes to Makefile out to reduce the diff noise.