Bug 234348 - games/aquaria: fix build with GCC-based architectures
Summary: games/aquaria: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2018-12-24 12:24 UTC by Piotr Kubaj
Modified: 2018-12-27 19:48 UTC (History)
2 users (show)

See Also:
jbeich: maintainer-feedback+

Attachments
patch (467 bytes, patch)
2018-12-24 12:24 UTC, Piotr Kubaj 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2018-12-24 12:24:13 UTC 
Created attachment 200447 [details]
patch

This port requires USES=compiler:c++11-lang to build on GCC architectures.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 Jan Beich freebsd_committer freebsd_triage 2018-12-26 15:45:17 UTC 
Can you show error log? This port was created when FreeBSD 9.x was still supported, so it built fine with GCC 4.2. If something did change it should be documented in the commit message.

If you don't provide rationale (i.e., the "why?") I can't reason about whether the fix is correct. Otherwise, for rubberstamping without regard for future maintenance "portmgr blanket" is enough.
Comment 2 Piotr Kubaj freebsd_committer freebsd_triage 2018-12-27 05:30:15 UTC 
(In reply to Jan Beich from comment #1)
https://talos.anongoth.pl/data/powerpc64-default/2018-12-21_17h43m05s/logs/errors/aquaria-1.002.22_5.log

[103/131] /usr/bin/c++  -DAQUARIA_BUILD_CONSOLE=1 -DAQUARIA_BUILD_SCENEEDITOR=1 -DAQUARIA_DEFAULT_DATA_DIR=\"/usr/local/share/aquaria\" -DBBGE_BUILD_ACHIEVEMENTS_INTERNAL=1 -DBBGE_BUILD_FMOD_OPENAL_BRIDGE=1 -DBBGE_BUILD_FRAMEBUFFER=1 -DBBGE_BUILD_OPENGL=1 -DBBGE_BUILD_OPENGL_DYNAMIC=1 -DBBGE_BUILD_SDL2=1 -DBBGE_BUILD_SDL=1 -DBBGE_BUILD_SHADERS=1 -DBBGE_BUILD_UNIX=1 -DBBGE_BUILD_VFS=1 -DBBGE_SKIP_CONFIG_HEADERS=1 -DBBGE_USE_GLM=1 -DGL_GLEXT_LEGACY=1 -DHAVE_PUTENV=1 -DHAVE_STRCASECMP -DLUA_USE_ULONGJMP=1 -DNDEBUG -DTIXML_USE_STL=1 -DVFS_ENABLE_C_API=1 -IBBGE -IBBGE/GL -I/usr/local/include -IAquaria -I/usr/local/include/FTGL -I/usr/local/include/freetype2 -I/usr/local/include/lua51 -I/usr/local/include/ogg -I/usr/local/include/vorbis -I/usr/local/include/SDL2 -I/usr/local/include/AL -IExternalLibs -IExternalLibs/ttvfs -IExternalLibs/ttvfs_zip -IExternalLibs/ttvfs_cfileapi -O2 -pipe -fno-strict-aliasing -O2 -pipe -fno-strict-aliasing -MD -MT CMakeFiles/aquaria.dir/BBGE/RenderObject.cpp.o -MF CMakeFiles/aquaria.dir/BBGE/RenderObject.cpp.o.d -o CMakeFiles/aquaria.dir/BBGE/RenderObject.cpp.o -c BBGE/RenderObject.cpp
FAILED: CMakeFiles/aquaria.dir/BBGE/RenderObject.cpp.o 
/usr/bin/c++  -DAQUARIA_BUILD_CONSOLE=1 -DAQUARIA_BUILD_SCENEEDITOR=1 -DAQUARIA_DEFAULT_DATA_DIR=\"/usr/local/share/aquaria\" -DBBGE_BUILD_ACHIEVEMENTS_INTERNAL=1 -DBBGE_BUILD_FMOD_OPENAL_BRIDGE=1 -DBBGE_BUILD_FRAMEBUFFER=1 -DBBGE_BUILD_OPENGL=1 -DBBGE_BUILD_OPENGL_DYNAMIC=1 -DBBGE_BUILD_SDL2=1 -DBBGE_BUILD_SDL=1 -DBBGE_BUILD_SHADERS=1 -DBBGE_BUILD_UNIX=1 -DBBGE_BUILD_VFS=1 -DBBGE_SKIP_CONFIG_HEADERS=1 -DBBGE_USE_GLM=1 -DGL_GLEXT_LEGACY=1 -DHAVE_PUTENV=1 -DHAVE_STRCASECMP -DLUA_USE_ULONGJMP=1 -DNDEBUG -DTIXML_USE_STL=1 -DVFS_ENABLE_C_API=1 -IBBGE -IBBGE/GL -I/usr/local/include -IAquaria -I/usr/local/include/FTGL -I/usr/local/include/freetype2 -I/usr/local/include/lua51 -I/usr/local/include/ogg -I/usr/local/include/vorbis -I/usr/local/include/SDL2 -I/usr/local/include/AL -IExternalLibs -IExternalLibs/ttvfs -IExternalLibs/ttvfs_zip -IExternalLibs/ttvfs_cfileapi -O2 -pipe -fno-strict-aliasing -O2 -pipe -fno-strict-aliasing -MD -MT CMakeFiles/aquaria.dir/BBGE/RenderObject.cpp.o -MF CMakeFiles/aquaria.dir/BBGE/RenderObject.cpp.o.d -o CMakeFiles/aquaria.dir/BBGE/RenderObject.cpp.o -c BBGE/RenderObject.cpp
In file included from /usr/local/include/glm/detail/setup.hpp:30,
                 from /usr/local/include/glm/detail/type_int.hpp:6,
                 from /usr/local/include/glm/fwd.hpp:6,
                 from /usr/local/include/glm/glm.hpp:61,
                 from BBGE/RenderObject.cpp:29:
/usr/local/include/glm/detail/../simd/platform.h:206:4: error: #error "GLM requires GCC 4.7 or higher"
/usr/local/include/glm/detail/../simd/platform.h:230:3: error: #error "GLM_COMPILER undefined, your compiler may not be supported by GLM. Add #define GLM_COMPILER 0 to ignore this message."
Comment 3 commit-hook freebsd_committer freebsd_triage 2018-12-27 19:46:10 UTC 
A commit references this bug:

Author: jbeich
Date: Thu Dec 27 19:45:19 UTC 2018
New revision: 488561
URL: https://svnweb.freebsd.org/changeset/ports/488561

Log:
  games/aquaria: unbreak on GCC architectures after r455508

  In file included from /usr/local/include/glm/detail/setup.hpp:30,
                   from /usr/local/include/glm/detail/type_int.hpp:6,
                   from /usr/local/include/glm/fwd.hpp:6,
                   from /usr/local/include/glm/glm.hpp:61,
                   from BBGE/RenderObject.cpp:29:
  /usr/local/include/glm/detail/../simd/platform.h:206:4: error: #error "GLM requires GCC 4.7 or higher"
  /usr/local/include/glm/detail/../simd/platform.h:230:3: error: #error "GLM_COMPILER undefined, your compiler may not be supported by GLM. Add #define GLM_COMPILER 0 to ignore this message."

  https://github.com/g-truc/glm/commit/dd48b56e44d6

  PR:		234348
  Submitted by:	Piotr Kubaj

Changes:
  head/games/aquaria/Makefile
Comment 4 commit-hook freebsd_committer freebsd_triage 2018-12-27 19:47:14 UTC 
A commit references this bug:

Author: jbeich
Date: Thu Dec 27 19:46:50 UTC 2018
New revision: 488562
URL: https://svnweb.freebsd.org/changeset/ports/488562

Log:
  MFH: r488561

  games/aquaria: unbreak on GCC architectures after r455508

  In file included from /usr/local/include/glm/detail/setup.hpp:30,
                   from /usr/local/include/glm/detail/type_int.hpp:6,
                   from /usr/local/include/glm/fwd.hpp:6,
                   from /usr/local/include/glm/glm.hpp:61,
                   from BBGE/RenderObject.cpp:29:
  /usr/local/include/glm/detail/../simd/platform.h:206:4: error: #error "GLM requires GCC 4.7 or higher"
  /usr/local/include/glm/detail/../simd/platform.h:230:3: error: #error "GLM_COMPILER undefined, your compiler may not be supported by GLM. Add #define GLM_COMPILER 0 to ignore this message."

  https://github.com/g-truc/glm/commit/dd48b56e44d6

  PR:		234348
  Submitted by:	Piotr Kubaj
  Approved by:	ports-secteam blanket

Changes:
_U  branches/2018Q4/
  branches/2018Q4/games/aquaria/Makefile
Comment 5 Jan Beich freebsd_committer freebsd_triage 2018-12-27 19:48:24 UTC 
Thanks for the error log. Landed.