Bug 234425 - devel/protobuf: Fix build for powerpcspe and likely powerpc(32)
Summary: devel/protobuf: Fix build for powerpcspe and likely powerpc(32)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-26 20:47 UTC by Justin Hibbits
Modified: 2019-01-05 23:21 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
Patch to link in libatomic on 32-bit archs with no 64-bit atomics (2.33 KB, patch)
2018-12-26 20:47 UTC, Justin Hibbits 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Hibbits freebsd_committer freebsd_triage 2018-12-26 20:47:30 UTC 
Created attachment 200539 [details]
Patch to link in libatomic on 32-bit archs with no 64-bit atomics

devel/protobuf needs to link against libatomic for 64-bit atomics when built with ports gcc on platforms that don't have 64-bit atomic operations.  The attached patch, obtained from upstream and massaged to fit our version, fixes this.  The patch is already included in the next version of protobuf.
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-01-05 22:48:25 UTC 
A commit references this bug:

Author: sunpoet
Date: Sat Jan  5 22:47:17 UTC 2019
New revision: 489414
URL: https://svnweb.freebsd.org/changeset/ports/489414

Log:
  Fix build on powerpcspe with linking to libatomic

  Obtained from:	https://github.com/protocolbuffers/protobuf/commit/56b40a8f055cfd05633054aed5d3466a6e058b72
  PR:		234425
  Submitted by:	jhibbits

Changes:
  head/devel/protobuf/files/patch-configure.ac
  head/devel/protobuf/files/patch-src-Makefile.am
  head/devel/protobuf/files/patch-tests.sh
Comment 2 Po-Chuan Hsieh freebsd_committer freebsd_triage 2019-01-05 23:21:24 UTC 
Committed. Thanks!