Bug 234515 - upgrade devel/jech-dht to 0.26
Summary: upgrade devel/jech-dht to 0.26
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexandre C. Guimarães
URL: https://reviews.freebsd.org/D19820
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-31 00:33 UTC by Mikhail Teterin
Modified: 2019-04-05 06:27 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (freebsd-2024)

Attachments
Upgrade to 0.26 (6.20 KB, patch)
2018-12-31 00:33 UTC, Mikhail Teterin 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Teterin freebsd_committer freebsd_triage 2018-12-31 00:33:40 UTC 
Created attachment 200637 [details]
Upgrade to 0.26

Just as we upgraded from 0.22 to 0.25, a new release is with the following items in changelog:

16 December 2018: dht-0.26

  * Fixed a bug introduced in 0.25 that prevented replying to find_nodes
    when want was not set.
  * Rename dht_callback to dht_callback_t.  This is an incompatible change.

Transmission-daemon failed to link (dht_sendto() unknown) -- rigoletto@, could you, please, look into it? Thank you!

(P.S. Would you like to take over maintainership, maybe?)
Comment 1 Alexandre C. Guimarães freebsd_committer freebsd_triage 2018-12-31 02:11:55 UTC 
Hi.

I was planning to update devel/jech-dht to 0.26 tomorrow. ^^

Sure I will look into it (tomorrow its late in here), and yes would be a good idea for me to also keep jech-dht to have some control when it break transmission.

Thanks!
Comment 2 Alexandre C. Guimarães freebsd_committer freebsd_triage 2019-01-01 20:45:20 UTC 
Transmission upstream is supposedly to be working on a fix for that. I think it is a better idea to wait for them. In the meaning time I will be preparing the transmission ports to the upcoming v3.00 which seems will not take longer.
Comment 3 Alexandre C. Guimarães freebsd_committer freebsd_triage 2019-01-01 20:48:35 UTC 
Btw, I did a local fix reverting the `dht_callback` -> `dht_callback_t`, and it works; however it is not a proper fix for ports. ^^
Comment 4 Alexandre C. Guimarães freebsd_committer freebsd_triage 2019-04-05 06:27:38 UTC 
Thank you.
Comment 5 commit-hook freebsd_committer freebsd_triage 2019-04-05 06:27:48 UTC 
A commit references this bug:

Author: rigoletto
Date: Fri Apr  5 06:26:50 UTC 2019
New revision: 497937
URL: https://svnweb.freebsd.org/changeset/ports/497937

Log:
  devel/jech-dht: Update to 0.26.

  PR:		234515
  Submitted by:	mi
  Reviewed by:	mat (mentor)
  Approved by:	tcberner (mentor)
  Differential Revision:	https://reviews.freebsd.org/D19820

Changes:
  head/devel/jech-dht/Makefile
  head/devel/jech-dht/distinfo
  head/devel/jech-dht/files/BSDmakefile
  head/devel/jech-dht/files/patch-warns