Bug 234697 - sysutils/py-mqttwarn: Do not set RUN_DEPENDS twice
Summary: sysutils/py-mqttwarn: Do not set RUN_DEPENDS twice
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dan Langille
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-07 17:41 UTC by Tobias Kortkamp
Modified: 2019-01-07 19:07 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (dvl)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer freebsd_triage 2019-01-07 17:41:27 UTC 
Due to setting RUN_DEPENDS twice, only sysutils/py-supervisor is actually
registered as a run dependency.  Is net/py-paho-mqtt also needed at runtime
or can it be removed?
Comment 1 Dan Langille freebsd_committer freebsd_triage 2019-01-07 18:16:15 UTC 
I often do:

RUN_DEPENDS+=

Without looking, it sounds like I missed a +

I will investigate.
Comment 2 Dan Langille freebsd_committer freebsd_triage 2019-01-07 18:20:46 UTC 
Confirmed at https://github.com/jpmens/mqttwarn ... paho-mqtt is required.
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-01-07 18:29:30 UTC 
A commit references this bug:

Author: dvl
Date: Mon Jan  7 18:29:23 UTC 2019
New revision: 489602
URL: https://svnweb.freebsd.org/changeset/ports/489602

Log:
  Fix depends so that net/py-paho-mqtt actually gets installed.

  PR:		234697
  Reported by:	tobik[B
  MFH:		2019Q1 (missing dependency)

Changes:
  head/sysutils/py-mqttwarn/Makefile
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-01-07 18:32:37 UTC 
A commit references this bug:

Author: dvl
Date: Mon Jan  7 18:32:01 UTC 2019
New revision: 489604
URL: https://svnweb.freebsd.org/changeset/ports/489604

Log:
  MFH: r489602

  Fix depends so that net/py-paho-mqtt actually gets installed.

  PR:		234697
  Reported by:	tobik

  Approved by:	ports-secteam (blanket)

Changes:
_U  branches/2019Q1/
  branches/2019Q1/sysutils/py-mqttwarn/Makefile
Comment 5 Tobias Kortkamp freebsd_committer freebsd_triage 2019-01-07 19:07:44 UTC 
Thanks.