Bug 234936 - multimedia/musikcube: fix build with GCC-based architectures
Summary: multimedia/musikcube: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL: https://github.com/clangen/musikcube/...
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-14 13:06 UTC by Piotr Kubaj
Modified: 2019-01-16 04:47 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (yuri)

Attachments
patch (919 bytes, patch)
2019-01-14 13:06 UTC, Piotr Kubaj 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-01-14 13:06:31 UTC 
Created attachment 201119 [details]
patch

Building with GCC8 requires including <functional> in src/plugins/sndioout/SndioOut.cpp for std::bind.

Tested on powerpc64 and amd64.

Hardwaro sponsored by IntegriCloud.
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2019-01-15 08:02:34 UTC 
It seems that this include is missing in some other files, not on the one that the patch fixes. I asked the upstream to fix this, and will wait for them.
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2019-01-16 04:47:33 UTC 
Committed the fix for this issue.
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-01-16 04:47:54 UTC 
A commit references this bug:

Author: yuri
Date: Wed Jan 16 04:47:28 UTC 2019
New revision: 490443
URL: https://svnweb.freebsd.org/changeset/ports/490443

Log:
  multimedia/musikcube: Update 0.60.2 -> 0.61.0-1

  PR#234936 suggested the patch to fix the missing include.
  Instead, I asked the upstream to fix it, which they did.
  This fix is included in this update.

  PR:		234936
  Reported by:	Piotr Kubaj <pkubaj@anongoth.pl>

Changes:
  head/multimedia/musikcube/Makefile
  head/multimedia/musikcube/distinfo
  head/multimedia/musikcube/pkg-plist