Bug 234940 - devel/geany-plugins: fix build with GCC-based architectures
Summary: devel/geany-plugins: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-14 13:27 UTC by Piotr Kubaj
Modified: 2019-01-14 18:51 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (madpilot)

Attachments
patch (405 bytes, patch)
2019-01-14 13:27 UTC, Piotr Kubaj 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-01-14 13:27:58 UTC 
Created attachment 201124 [details]
patch

devel/geany-plugin-markdown requires includes from webkit2-gtk3 which have redefine some typedefs. Typedef redefinitions are not supported by base GCC, so use ports GCC for this plugin on GCC architectures.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-01-14 18:49:19 UTC 
A commit references this bug:

Author: madpilot
Date: Mon Jan 14 18:48:54 UTC 2019
New revision: 490311
URL: https://svnweb.freebsd.org/changeset/ports/490311

Log:
  Fix build of the markdown geaany plugin with GCC-based architectures.

  The markdown requires includes from webkit2-gtk3 which have redefine
  some typedefs. Typedef redefinitions are not supported by base GCC,
  so use ports GCC for this plugin on GCC architectures.

  PR:		234940
  Submitted by:	Piotr Kubaj <pkubaj@anongoth.pl>

Changes:
  head/devel/geany-plugins/files/Makefile.common
Comment 2 Guido Falsi freebsd_committer freebsd_triage 2019-01-14 18:51:52 UTC 
Hi,

Thanks for signaling this.

I committed a similar patch. Your patch would have broken flavoring, since also the other variables defined in the else stanza are needed by the markdown plugin, especially the ones conditional on flavor.

I added a further .if inside the else block to cater for it. I also added a comment as a note to myself to avoid removing that if conditional in the future if I forget about this PR.