Bug 235069 - fix build of irc/iroffer-dinoex on non-x86 architectures
Summary: fix build of irc/iroffer-dinoex on non-x86 architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dirk Meyer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-19 20:05 UTC by Mark Linimon
Modified: 2019-01-28 14:18 UTC (History)
0 users

See Also:
dinoex: maintainer-feedback+


Attachments
patch to Makefile (1.00 KB, patch)
2019-01-19 20:05 UTC, Mark Linimon
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Linimon freebsd_committer freebsd_triage 2019-01-19 20:05:50 UTC
Created attachment 201276 [details]
patch to Makefile

devel/libunwind is only available for x86.  This blocks a great many ports from building on e.g. powerpc64.

This patch conditionalizes that dependency.
Comment 1 Dirk Meyer freebsd_committer freebsd_triage 2019-01-19 21:37:47 UTC
Thank you very much.

I will merge the patch soon.
Comment 2 Dirk Meyer freebsd_committer freebsd_triage 2019-01-19 21:48:17 UTC
As I see now all supported versions of ruby do now record libunwind as dependency.

The conditional LIB_DEPENDS in iroffer is no longer needed on all architectures.
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-01-28 13:46:46 UTC
A commit references this bug:

Author: dinoex
Date: Mon Jan 28 13:46:20 UTC 2019
New revision: 491485
URL: https://svnweb.freebsd.org/changeset/ports/491485

Log:
  - fix build on non-x86 architectures
  PR:		235069
  Submitted by:	Mark Linimon

Changes:
  head/irc/iroffer-dinoex/Makefile