Bug 235126 - [PATCH] devel/thunar-vcs-plugin: modernize and cleanup port
Summary: [PATCH] devel/thunar-vcs-plugin: modernize and cleanup port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-22 14:49 UTC by Guido Falsi
Modified: 2019-01-22 18:51 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (sergey.dyatko)

Attachments
patch (2.17 KB, patch)
2019-01-22 14:49 UTC, Guido Falsi 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Guido Falsi freebsd_committer freebsd_triage 2019-01-22 14:49:39 UTC 
Created attachment 201330 [details]
patch

Hi,

I've committed a general cleanup and modernization patch for xfce ports in r490953.

I also made similar changes to devel/thunar-vcs-plugin.

In particular:

- Removed unneeded patch
- Added missing dependencies
- Changed variable order to please portlint
- Cosmetic changes, like sorting things and reflowing OPTIONS related parts

Can you approve this patch?

Thanks.
Comment 1 Sergey V. Dyatko 2019-01-22 16:12:42 UTC 
Feel free to commit it
Thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-01-22 18:49:22 UTC 
A commit references this bug:

Author: madpilot
Date: Tue Jan 22 18:48:38 UTC 2019
New revision: 490972
URL: https://svnweb.freebsd.org/changeset/ports/490972

Log:
  - Add missing dependencies
  - Remove unneeded patch
  - Sort lists
  - Fix portlint warnings
  - Some cosmetic changes

  PR:		235126
  Submitted by:	myself
  Approved by:	Sergey V. Dyatko <sergey.dyatko@gmail.com>

Changes:
  head/devel/thunar-vcs-plugin/Makefile
  head/devel/thunar-vcs-plugin/files/
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2019-01-22 18:51:07 UTC 
Committed. Thanks!