Bug 235222 - sysutils/ipfs-go: fix rc script when default ipfs_go_path is used
Summary: sysutils/ipfs-go: fix rc script when default ipfs_go_path is used
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: John Hixson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-26 21:47 UTC by Steve Wills
Modified: 2019-01-30 19:24 UTC (History)
2 users (show)

See Also:
jhixson: maintainer-feedback+

Attachments
initial patch to fix rc script (1.13 KB, patch)
2019-01-26 21:47 UTC, Steve Wills 		no flags Details | Diff
updated patch with multiple fixes (5.25 KB, patch)
2019-01-26 23:56 UTC, Steve Wills 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Wills freebsd_committer freebsd_triage 2019-01-26 21:47:34 UTC 
Created attachment 201425 [details]
initial patch to fix rc script

The change in r489638 broke the rc script because IPFS_HOME isn't substituted and the wrong default path is used. Here's a patch which fixes that. I may do some more improvements to the script but this at least makes it functional.
Comment 1 Steve Wills freebsd_committer freebsd_triage 2019-01-26 23:56:34 UTC 
Created attachment 201427 [details]
updated patch with multiple fixes

Ok, here's an updated version of the patch which:

* Fixes the rc script when default ipfs_go_path is used
* Fixes the logging by switching to uses the syslog logging in daemon
* Switches the init to using the --init flag to the ipfs daemon command
* Fixes the version string since the tarball provided by upstream doesn't match the tag for this release (has version string wrong)
* Allows overriding IPFS_USER/GROUP/HOME at build time
* Removes unnecessary BEFORE: LOGIN from rc script
Comment 2 John Hixson freebsd_committer freebsd_triage 2019-01-28 18:40:49 UTC 
Tested and confirmed working. LGTM.
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-01-30 19:23:26 UTC 
A commit references this bug:

Author: swills
Date: Wed Jan 30 19:22:54 UTC 2019
New revision: 491652
URL: https://svnweb.freebsd.org/changeset/ports/491652

Log:
  sysutils/ipfs-go: fix rc script

  * Fix the rc script when default ipfs_go_path is used
  * Fix the logging by switching to uses the syslog logging in daemon
  * Switch the init to using the --init flag to the ipfs daemon command
  * Fixes the version string since the tarball provided by upstream
    doesn't match the tag for this release (has version string wrong)
  * Allow overriding IPFS_USER/GROUP/HOME at build time
  * Remove unnecessary BEFORE: LOGIN from rc script

  PR:		235222
  Approved by:	jhixson (maintainer)

Changes:
  head/sysutils/ipfs-go/Makefile
  head/sysutils/ipfs-go/files/ipfs-go.in
  head/sysutils/ipfs-go/files/patch-version.go
  head/sysutils/ipfs-go/pkg-plist