Bug 235308 - print/cloud-print-connector: Add service/daemon script
Summary: print/cloud-print-connector: Add service/daemon script
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Only Me
Assignee: Steve Wills
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-30 07:50 UTC by Robert James Hernandez
Modified: 2019-02-01 12:15 UTC (History)
1 user (show)

See Also:
koobs: maintainer-feedback? (swills)


Attachments
gcp service patch (2.21 KB, text/plain)
2019-01-30 07:50 UTC, Robert James Hernandez
no flags Details
slightly updated patch (2.28 KB, patch)
2019-01-30 15:06 UTC, Steve Wills
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert James Hernandez 2019-01-30 07:50:28 UTC
Created attachment 201522 [details]
gcp service patch

Adding a daemon to gcp-print-connector port, currently the port does not have any traditional service. This also includes a pkg-message about how to generate a configuration file since it requires logging into your google account via an external web browser.

System info:
# uname -p -r -s
FreeBSD 10.4-RELEASE-p2 amd64

Pkg info:
# pkg info | grep cloud
cloud-print-connector-1.16     Share CUPS printers via Google Cloud Print
Comment 1 Steve Wills freebsd_committer freebsd_triage 2019-01-30 15:06:44 UTC
Created attachment 201534 [details]
slightly updated patch

I updated the script slightly, can you please verify?
Comment 2 Robert James Hernandez 2019-01-31 08:44:18 UTC
Thanks! I didnt get a chance to test this tonight, but Ill give it a spin in the morning.
Comment 3 Robert James Hernandez 2019-02-01 07:16:41 UTC
I was able to test your suggested changes and they look good, thanks for the help!

Let me know if theres anything else you need me to do.

~Rob
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-02-01 12:13:15 UTC
A commit references this bug:

Author: swills
Date: Fri Feb  1 12:12:32 UTC 2019
New revision: 491799
URL: https://svnweb.freebsd.org/changeset/ports/491799

Log:
  print/cloud-print-connector: Add service/daemon script

  PR:		235308
  Submitted by:	Robert James Hernandez <rob@sarcasticadmin.com> (modified slightly)

Changes:
  head/print/cloud-print-connector/Makefile
  head/print/cloud-print-connector/files/
  head/print/cloud-print-connector/files/gcp-cups-connectord.in
  head/print/cloud-print-connector/pkg-message
Comment 5 Steve Wills freebsd_committer freebsd_triage 2019-02-01 12:15:09 UTC
Committed, thanks!