Bug 235349 - x11-fm/worker: fix build with GCC-based architectures
Summary: x11-fm/worker: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mark Linimon
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-31 11:45 UTC by Piotr Kubaj
Modified: 2019-02-04 11:52 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (mp39590)

Attachments
patch (318 bytes, patch)
2019-01-31 11:45 UTC, Piotr Kubaj 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-01-31 11:45:12 UTC 
Created attachment 201558 [details]
patch

When compiling this port with GCC, the following warning is treated as error:
exprfilter_scanner.rl:114:1: warning: narrowing conversion of '-1' from 'int' to 'char' inside { } [-Wnarrowing]
exprfilter_scanner.rl:114:1: warning: narrowing conversion of '-1' from 'int' to 'char' inside { } [-Wnarrowing]
exprfilter_scanner.rl:114:1: warning: narrowing conversion of '-1' from 'int' to 'char' inside { } [-Wnarrowing]
exprfilter_scanner.rl:114:1: warning: narrowing conversion of '-1' from 'int' to 'char' inside { } [-Wnarrowing]
exprfilter_scanner.rl:114:1: warning: narrowing conversion of '-1' from 'int' to 'char' inside { } [-Wnarrowing]
exprfilter_scanner.rl:114:1: warning: narrowing conversion of '-1' from 'int' to 'char' inside { } [-Wnarrowing]

Add -Wno-error=narrowing to CXXFLAGS on GCC architectures to fix build.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-02-04 11:52:45 UTC 
A commit references this bug:

Author: linimon
Date: Mon Feb  4 11:52:13 UTC 2019
New revision: 492118
URL: https://svnweb.freebsd.org/changeset/ports/492118

Log:
  When compiling this port with GCC, the following warning is treated as error:

    exprfilter_scanner.rl:114:1: warning: narrowing conversion of '-1' from 'int' to 'char' inside { } [-Wnarrowing]

  Add -Wno-error=narrowing to CXXFLAGS on GCC-based architectures to fix
  the build.

  PR:		235349
  Submitted by:	Piotr Kubaj
  Approved by:	portmgr (tier-2 blanket)

Changes:
  head/x11-fm/worker/Makefile