Bug 235504 - x11-themes/greybird-theme: fix build with NOTIFYD=off
Summary: x11-themes/greybird-theme: fix build with NOTIFYD=off
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Koichiro Iwao
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2019-02-04 20:41 UTC by serpent7776
Modified: 2019-02-17 15:34 UTC (History)
1 user (show)

See Also:

Attachments
patch with fix (699 bytes, patch)
2019-02-04 20:41 UTC, serpent7776 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description serpent7776 2019-02-04 20:41:56 UTC 
Created attachment 201731 [details]
patch with fix

Greybird theme does not build when NOTIFYD option is disabled due to missed %%NOTIFYD%% in pkg-plist
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-02-13 06:47:19 UTC 
A commit references this bug:

Author: meta
Date: Wed Feb 13 06:46:30 UTC 2019
New revision: 492828
URL: https://svnweb.freebsd.org/changeset/ports/492828

Log:
  x11-themes/greybird-theme: fix build when NOTIFYD=off

  While here, increase PORTREVISION due to plist change.

  PR:		235504
  Submitted by:	serpent7776@gmail.com
  MFH:		2019Q1

Changes:
  head/x11-themes/greybird-theme/Makefile
  head/x11-themes/greybird-theme/pkg-plist
Comment 2 Koichiro Iwao freebsd_committer freebsd_triage 2019-02-13 06:52:07 UTC 
Committed with PORTVERSION bump, good catch!

When pkg-plist changed, PORTVERSION must be bumped.
https://www.freebsd.org/doc/en/books/porters-handbook/makefile-naming.html

After I MFH to quarterly, I close this.
Comment 3 Koichiro Iwao freebsd_committer freebsd_triage 2019-02-17 15:34:11 UTC 
This doesn't affect quarterly branch, closing.