Bug 235515 - games/pioneer: Update to 20190203
Summary: games/pioneer: Update to 20190203
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Tobias Kortkamp
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2019-02-05 08:56 UTC by lightside
Modified: 2019-02-07 13:30 UTC (History)
1 user (show)

See Also:

Attachments
Proposed patch (since 487272 revision) (5.68 KB, patch)
2019-02-05 08:56 UTC, lightside 		lightside: maintainer-approval+
Details | Diff
Proposed patch (since 487272 revision) (3.24 KB, patch)
2019-02-06 17:58 UTC, lightside 		lightside: maintainer-approval+
Details | Diff
Proposed patch (since 487272 revision) (3.61 KB, patch)
2019-02-06 18:29 UTC, lightside 		lightside: maintainer-approval+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description lightside 2019-02-05 08:56:06 UTC 
Created attachment 201743 [details]
Proposed patch (since 487272 revision)

Patch to update games/pioneer port from 20180203 to 20190203 version.

Look following links for changes:
https://github.com/pioneerspacesim/pioneer/compare/20180203...20190203
https://github.com/pioneerspacesim/pioneer/blob/20190203/Changelog.txt

- Use cmake build system
- Add INSTALLS_ICONS=yes [1]
- Remove MODELCOMPILER and SERVERAGENT port's options [2, 3]
- Add OPTMODELS port's option [3]
- Adapt some sed patches
- Add pkg-plist file for this case

1. The ports-mgmt/portlint (with using -C option) reported about following warning(s):
WARN: <..>: installing icons, please define INSTALLS_ICONS as appropriate
2. Looks like, the src/ServerAgent.[cpp|h] files wasn't changed for newer contrib/json library (for this release), because requires previous json/json.h include file, while json/json.hpp file available in contrib directory.
3. The current cmake's script(s) has instructions to build/install modelcompiler tool and use it to create optimized models (*.sgm files) after build, but possible to add a configurable port's option for this case.

The saved games from previous version are not compatible.
Comment 1 Steve Wills freebsd_committer freebsd_triage 2019-02-06 13:09:30 UTC 
Fails to build:

/wrkdirs/usr/ports/games/pioneer/work/pioneer-20190203/contrib/imgui/examples/imgui_impl_opengl3.cpp:83:10: fatal error: 'GL/glew.h' file not found
#include <GL/glew.h>
         ^~~~~~~~~~~
1 error generated.
Comment 2 lightside 2019-02-06 17:58:29 UTC 
Created attachment 201795 [details]
Proposed patch (since 487272 revision)

(In reply to comment #1)
Looks like, you found some build issue, when using (poudriere's) clean build environment. Thanks for testing.
I found how to fix current autotools build method, which worked before.

New description of changes:
- Add gl to USES
- Remove SERVERAGENT port's option
- Add EXTRA_WARNINGS, EXTERNAL_GLEW and EXTERNAL_LUA port's options
- Adapt some sed patch
- Add files/buildopts.h file with default values
Comment 3 lightside 2019-02-06 18:29:39 UTC 
Created attachment 201797 [details]
Proposed patch (since 487272 revision)

Moved GLEW license to EXTERNAL_GLEW_VARS_OFF case.
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-02-07 13:30:05 UTC 
A commit references this bug:

Author: tobik
Date: Thu Feb  7 13:29:47 UTC 2019
New revision: 492367
URL: https://svnweb.freebsd.org/changeset/ports/492367

Log:
  games/pioneer: Update to 20190203

  - While here move option descriptions before options helpers as
    recommended by the Porter's Handbook section 15.10.

  Changes:	https://github.com/pioneerspacesim/pioneer/compare/20180203...20190203
  Changes:	https://github.com/pioneerspacesim/pioneer/blob/20190203/Changelog.txt
  PR:		235515
  Submitted by:	lightside@gmx.com (maintainer)

Changes:
  head/games/pioneer/Makefile
  head/games/pioneer/distinfo
  head/games/pioneer/files/buildopts.h